Re: [PATCH v2 0/6] MR6636: d3dx9: Support for more pixel formats and DDS files containing a color palette.

[Connor McAdams (＠cmcadams)]

On Wed Oct  9 18:35:19 2024 +0000, Matteo Bruni wrote:
> Maybe also check that the other masks are 0? Ideally this should be tested.
> Good point, I hadn't considered this to be an issue. I have a patch written for detecting format by memcmp'ing a constant structure against the passed in file's pixel format structure. After writing some tests, it looks like there are certain fields that are ignored in the `struct dds_pixel_format` depending on what the flags field is set to, e.g if it's `DDS_PF_RGB` the `fourcc` field can be set to anything and it's ignored.

I will add some tests for this in my next MR. :)

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6636#note_84554