Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
12 Jul
2022
12 Jul
'22
3:14 a.m.
On Mon Jul 11 15:14:43 2022 +0000, Jinoh Kang wrote:
How about the following race-free approach? ```suggestion:-0+0 /* wait for I/O to start, which transitions the pipe handle from signaled to nonsignaled state. */ while ((wait_status = WaitForSingleObject(pipe, 0)) == WAIT_OBJECT_0) Sleep(1); ok(wait_status == WAIT_TIMEOUT, "WaitForSingleObject returned %lu (error %lu)\n", wait_status, GetLastError()); ``` Ditto for other places. i had copied the `Sleep(100)` from one of the sync.c tests, i think. but if it makes the test less flaky, i'll take it. thanks!
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3919
1250
Age (days ago)
1250
Last active (days ago)
0 comments
1 participants
participants (1)
-
Daniel Lehman (@dlehman25)