[PATCH 0/1] MR9894: cryptnet: Close leaking file handle in `find_cached_revocation_status`

[Michael Stopa (＠stomy)]

`find_cached_revocation_status` has only been closing file handles in failure cases. This causes a leak of stdio stream handles.

This will cause .NET MSBuild to fail to build sufficiently large projects once all stream I/O indexes are spoken for and `_wfsopen` fails.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9894

[PATCH 1/1] cryptnet: Close leaking file handle

[Michael Stopa]

From: Michael Stopa <[e-mail]>

`find_cached_revocation_status` has only been closing file handles in
failure cases. This causes a leak of stdio stream handles.
---
 dlls/cryptnet/cryptnet_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/cryptnet/cryptnet_main.c b/dlls/cryptnet/cryptnet_main.c
index 315432aa108..4432f38e5b8 100644
--- a/dlls/cryptnet/cryptnet_main.c
+++ b/dlls/cryptnet/cryptnet_main.c
@@ -1641,6 +1641,7 @@ static BOOL find_cached_revocation_status(const CERT_CONTEXT *cert, const CERT_R
     }
 
     TRACE("Using cached status %#lx, reason %#lx.\n", status->dwError, status->dwReason);
+    fclose(file);
     return TRUE;
 }
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/9894

[PATCH 0/1] MR9894: cryptnet: Close leaking file handle in `find_cached_revocation_status` - approved

[Hans Leidekker (＠hans)]

This merge request was approved by Hans Leidekker.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9894