[PATCH 0/1] MR7964: quartz/tests: Mark a pause test in test_media_event as flaky.
This test failed on Linux 2 out of the last 67 times on test.winehq.org because IMediaControl_GetState returned VFW_S_STATE_INTERMEDIATE, evidently meaning that the command to pause had been received but not yet carried out. Since pausing is an asynchronous operation in Wine's implementation, mark the test as flaky. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7964
From: Alex Henrie <alexhenrie24(a)gmail.com> This test failed on Linux 2 out of the last 67 times on test.winehq.org because IMediaControl_GetState returned VFW_S_STATE_INTERMEDIATE, evidently meaning that the command to pause had been received but not yet carried out. Since pausing is an asynchronous operation in Wine's implementation, mark the test as flaky. --- dlls/quartz/tests/filtergraph.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/quartz/tests/filtergraph.c b/dlls/quartz/tests/filtergraph.c index df1f02cfd00..c2b9881c14d 100644 --- a/dlls/quartz/tests/filtergraph.c +++ b/dlls/quartz/tests/filtergraph.c @@ -532,6 +532,7 @@ static void test_media_event(IFilterGraph2 *graph) hr = IMediaControl_Pause(control); ok(SUCCEEDED(hr), "Got hr %#lx.\n", hr); hr = IMediaControl_GetState(control, 1000, &state); + flaky_wine ok(hr == S_OK, "Got hr %#lx.\n", hr); ok(state == State_Paused, "Got state %ld.\n", state); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/7964
Can we raise the timeout instead? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7964#note_102590
On Tue May 6 03:17:33 2025 +0000, Elizabeth Figura wrote:
Can we raise the timeout instead? Yeah, that should work.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7964#note_102630
participants (3)
-
Alex Henrie -
Alex Henrie (＠alexhenrie)
-
Elizabeth Figura (＠zfigura)