[PATCH v2 0/149] MR7462: Release 9.0.1.
-- v2: Release 9.0.1. wbemprox: Use separate critical sections for tables and table list. kernel32/tests: Add tests for critical section debug info presence. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7462
With cb0345969c7b0fc3201a87b6ff6949db4380b255 included, maybe other related fixes like !6367, !6424, !6667, and !6994 would be worth including too? Maybe also worth considering !5034 !5076 !5257 as explorer / systray fixes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7462#note_98063
On Tue Mar 18 22:09:53 2025 +0000, Michael Stefaniuc wrote:
Thanks for notifying me, my scripts had no chance of finding the regression as there's no bug for it nor a reference to the commit introducing the regression. Now there is an issue with e7ff2688 as it depends on RTL_CRITICAL_SECTION_FLAG_FORCE_DEBUG_INFO introduced with 0b441c4c8ff9 / MR!5071. @gofman I'm assuming I can pull in 0b441c4c8ff9 that defines RTL_CRITICAL_SECTION_FLAG_FORCE_DEBUG_INFO and then e7ff2688 which uses it. I mean without producing any adverse effect. The critical section will have that flag set but nothing will make use of it and more importantly not barf when it sees that. The alternative is to just drop 9015eebf if this produces too much hassle. e7ff2688 cherry picked too.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7462#note_98326
On Tue Mar 18 22:47:30 2025 +0000, Rémi Bernon wrote:
With cb0345969c7b0fc3201a87b6ff6949db4380b255 included, maybe other related fixes like !6367, !6424, !6667, and !6994 would be worth including too? Maybe also worth considering !5034 !5076 !5257 as explorer / systray fixes. It's a while but afair I looked at more of those.\ E.g. c31e65fd3bd from !6367 had its own "regression" `[57243] taskbar is gone inside virtual desktop` but also depends on commit b5c57b9a62c which regresses `[56337] battle.net: tray icon is not displayed with wine-9.2`. That regression is most likely fixed by 8a71a4a3049 but not visible in the bug. Oh and 8a71a4a3049 is referenced by b1a61e74a38.
!6994 on the other hand fixes a regression introduced in 9.x and my script ignores those if I didn't pick up that commit. And then due to the too many changes in explorer / systray those patches start to depend on those regression + fix and it becomes too much churn. And too risky to be Stable material. I can pull in !5034, !5076 and !5257 as those are b5c57b9a62c (fixes a regression from 9.0) respectively 8a71a4a3049 and b1a61e74a38. But only if 8a71a4a3049 is the fix for bug 56337 and there are no fixes required that my scripts can't find. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7462#note_98343
On Fri Mar 21 07:18:21 2025 +0000, Michael Stefaniuc wrote:
It's a while but afair I looked at more of those.\ E.g. c31e65fd3bd from !6367 had its own "regression" `[57243] taskbar is gone inside virtual desktop` but also depends on commit b5c57b9a62c which regresses `[56337] battle.net: tray icon is not displayed with wine-9.2`. That regression is most likely fixed by 8a71a4a3049 but not visible in the bug. Oh and 8a71a4a3049 is referenced by b1a61e74a38. !6994 on the other hand fixes a regression introduced in 9.x and my script ignores those if I didn't pick up that commit. And then due to the too many changes in explorer / systray those patches start to depend on those regression + fix and it becomes too much churn. And too risky to be Stable material. I can pull in !5034, !5076 and !5257 as those are b5c57b9a62c (fixes a regression from 9.0) respectively 8a71a4a3049 and b1a61e74a38. But only if 8a71a4a3049 is the fix for bug 56337 and there are no fixes required that my scripts can't find. Hmm, yeah it was messy sorry about that. Well lets forget about it then.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7462#note_98581
This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7462
This merge request was approved by Nikolay Sivov. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7462
This merge request was approved by Jacek Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7462
This merge request was approved by Hans Leidekker. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7462
This merge request was approved by Piotr Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7462
This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7462
This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7462
This merge request was approved by Michael Stefaniuc. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7462
This merge request was approved by Matteo Bruni. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7462
This merge request was approved by Esme Povirk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7462
participants (10)
-
Esme Povirk (＠madewokherd) -
Hans Leidekker (＠hans)
-
Huw Davies (＠huw)
-
Jacek Caban (＠jacek)
-
Jan Sikorski (＠jsikorski)
-
Matteo Bruni (＠Mystral)
-
Michael Stefaniuc (＠mstefani)
-
Nikolay Sivov (＠nsivov)
-
Piotr Caban (＠piotr)
-
Rémi Bernon