[PATCH 0/1] MR3039: shell32: Fix memory leak on error path in FolderItems_Constructor (scan-build).
From: Alex Henrie <alexhenrie24(a)gmail.com> --- dlls/shell32/shelldispatch.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/shell32/shelldispatch.c b/dlls/shell32/shelldispatch.c index 01353bda82d..dd58c755c61 100644 --- a/dlls/shell32/shelldispatch.c +++ b/dlls/shell32/shelldispatch.c @@ -1682,6 +1682,7 @@ static HRESULT FolderItems_Constructor(FolderImpl *folder, FolderItems **ret) return S_OK; failed: + FolderItemsImpl_Release(&This->FolderItems3_iface); if (enumidlist) IEnumIDList_Release(enumidlist); return hr; -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/3039
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=133682 Your paranoid android. === debian11 (32 bit report) === user32: msg.c:6897: Test failed: SetFocus(hwnd) on a button: 4: the msg 0x0007 was expected, but got msg 0x0005 instead msg.c:6897: Test failed: SetFocus(hwnd) on a button: 5: the msg 0x0138 was expected, but got msg 0x030f instead msg.c:6897: Test failed: SetFocus(hwnd) on a button: 6: the msg 0x0111 was expected, but got msg 0x001c instead msg.c:6897: Test failed: SetFocus(hwnd) on a button: 8: the msg 0x8000 was expected, but got msg 0x0086 instead msg.c:6897: Test failed: SetFocus(hwnd) on a button: 9: the msg sequence is not complete: expected 0000 - actual 0006
This merge request was approved by Nikolay Sivov. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3039
participants (4)
-
Alex Henrie -
Alex Henrie (＠alexhenrie)
-
Marvin -
Nikolay Sivov (＠nsivov)