[PATCH 0/1] MR9261: uxtheme: Hide a few unused ordinals.
From: Louis Lenders <xerox.xerox2000x(a)gmail.com> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58747 --- dlls/uxtheme/uxtheme.spec | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/uxtheme/uxtheme.spec b/dlls/uxtheme/uxtheme.spec index 78530a0b755..56fd8f81b84 100644 --- a/dlls/uxtheme/uxtheme.spec +++ b/dlls/uxtheme/uxtheme.spec @@ -13,8 +13,8 @@ 15 stub -noname DumpLoadedThemeToTextFile 16 stub -noname OpenThemeDataFromFile 17 stub -noname OpenThemeFileFromData -18 stub -noname GetThemeSysSize96 -19 stub -noname GetThemeSysFont96 +# 18 stub -noname GetThemeSysSize96 +# 19 stub -noname GetThemeSysFont96 20 stub -noname SessionAllocate 21 stub -noname SessionFree 22 stub -noname ThemeHooksOn -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/9261
Hi Zhiyi, I did some more testing and I found that the program can also be started by just removing one ordinal from the uxtheme.spec file (instead of moving one of the named functions above DrawThemeBackground to an (arbitrary) ordinal). I've tested that on win7 up to win11 ordinals 18 up to 30 seem to be unused. On windows Vista only 18 + 19 seem unused. So this patch seems like a reasonable fix to start the program. See also https://testbot.winehq.org/JobDetails.pl?Key=160413#k201 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9261#note_119433
On Thu Oct 23 13:35:12 2025 +0000, Louis Lenders wrote:
Hi Zhiyi, I did some more testing and I found that the program can also be started by just removing one ordinal from the uxtheme.spec file (instead of moving one of the named functions above DrawThemeBackground to an (arbitrary) ordinal). I've tested that on win7 up to win11 ordinals 18 up to 30 seem to be unused. On windows Vista only 18 + 19 seem unused. So this patch seems like a reasonable fix to start the program. See also https://testbot.winehq.org/JobDetails.pl?Key=160413#k201 On 64-bit Windows 10 22H2, ordinals 18 and 19 are used in uxtheme. So I am not convinced that this is the right way to fix it. Please try to find out why the program crashes. You can add some logs in GetProcAddress() to see which ordinal in uxtheme it needs.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9261#note_119447
Hi Zhiyi,
On 64-bit Windows 10 22H2, ordinals 18 and 19 are used in uxtheme. How exactly do you know that. In the test I mentioned in comment 1 they are not present afaict.
Please try to find out why the program crashes. You can add some logs in >GetProcAddress() to see which ordinal in uxtheme it needs.
I've put some info here https://bugs.winehq.org/show_bug.cgi?id=58747#c1 I'don't know what to make of these findings atm. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9261#note_119561
On Fri Oct 24 14:49:43 2025 +0000, Louis Lenders wrote:
Hi Zhiyi,
On 64-bit Windows 10 22H2, ordinals 18 and 19 are used in uxtheme. How exactly do you know that. In the test I mentioned in comment 1 they are not present afaict. Please try to find out why the program crashes. You can add some logs in >GetProcAddress() to see which ordinal in uxtheme it needs. I've put some info here https://bugs.winehq.org/show_bug.cgi?id=58747#c1 I'don't know what to make of these findings atm. I created https://gitlab.winehq.org/wine/wine/-/merge_requests/9274
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9261#note_119567
On Fri Oct 24 14:49:43 2025 +0000, Zhiyi Zhang wrote:
I created https://gitlab.winehq.org/wine/wine/-/merge_requests/9274 Ok, thanks! I'll close this one then.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9261#note_119569
Superseded by !9274 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9261#note_119570
This merge request was closed by Louis Lenders. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9261
participants (3)
-
Louis Lenders -
Louis Lenders (＠xe)
-
Zhiyi Zhang (＠zhiyi)