[PATCH 0/1] MR308: vkd3d-shader/hlsl: Initialize all constant values in hlsl_fold_constant_swizzles().

[Francisco Casas (＠fcasas)]

Even though the uninitialized values shouldn't be used in the output
binary program, they still show up in it, and affect the checksum, so
we better make them zeroes.

This error was reported by valgrind:

```
libtool --mode=execute valgrind --track-origins=yes vkd3d-build/tests/shader_runner vkd3d/tests/hlsl/static-initializer.shader_test
```

```
==46180== Conditional jump or move depends on uninitialised value(s)
==46180==    at 0x48D98C7: parse_dxbc.isra.0 (dxbc.c:182)
==46180==    by 0x48DA044: vkd3d_shader_parse_dxbc (dxbc.c:308)
==46180==    by 0x488D1B6: vkd3d_shader_parse_dxbc_source_type (vkd3d_shader_utils.h:37)
==46180==    by 0x488D1B6: create_shader_stage.isra.0 (state.c:1988)
==46180==    by 0x48926B6: d3d12_pipeline_state_init_graphics (state.c:3084)
==46180==    by 0x4893A96: d3d12_pipeline_state_create_graphics (state.c:3280)
==46180==    by 0x4878498: d3d12_device_CreateGraphicsPipelineState (device.c:2619)
==46180==    by 0x1FFEFFECC7: ???
==46180==    by 0xE8: ???
==46180==    by 0x47: ???
==46180==    by 0x61: ???
==46180==    by 0x660066000000023: ???
==46180==    by 0x661066100000044: ???
==46180==  Uninitialised value was created by a stack allocation
==46180==    at 0x48F3FF0: hlsl_fold_constant_swizzles (hlsl_constant_ops.c:1010)
```

Thank you valgrind! :smile:

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/308

[PATCH 1/1] vkd3d-shader/hlsl: Initialize all constant values in hlsl_fold_constant_swizzles().

[Francisco Casas]

From: Francisco Casas <fcasas(a)codeweavers.com>

Even though the uninitialized values shouldn't be used in the output
binary program, they still show up in it, and affect the checksum, so
we better make them zeroes.

This error was reported by valgrind

    libtool --mode=execute valgrind --track-origins=yes vkd3d-build/tests/shader_runner vkd3d/tests/hlsl/static-initializer.shader_test

    ==46180== Conditional jump or move depends on uninitialised value(s)
    ==46180==    at 0x48D98C7: parse_dxbc.isra.0 (dxbc.c:182)
    ==46180==    by 0x48DA044: vkd3d_shader_parse_dxbc (dxbc.c:308)
    ==46180==    by 0x488D1B6: vkd3d_shader_parse_dxbc_source_type (vkd3d_shader_utils.h:37)
    ==46180==    by 0x488D1B6: create_shader_stage.isra.0 (state.c:1988)
    ==46180==    by 0x48926B6: d3d12_pipeline_state_init_graphics (state.c:3084)
    ==46180==    by 0x4893A96: d3d12_pipeline_state_create_graphics (state.c:3280)
    ==46180==    by 0x4878498: d3d12_device_CreateGraphicsPipelineState (device.c:2619)
    ==46180==    by 0x1FFEFFECC7: ???
    ==46180==    by 0xE8: ???
    ==46180==    by 0x47: ???
    ==46180==    by 0x61: ???
    ==46180==    by 0x660066000000023: ???
    ==46180==    by 0x661066100000044: ???
    ==46180==  Uninitialised value was created by a stack allocation
    ==46180==    at 0x48F3FF0: hlsl_fold_constant_swizzles (hlsl_constant_ops.c:1010)
---
 libs/vkd3d-shader/hlsl_constant_ops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libs/vkd3d-shader/hlsl_constant_ops.c b/libs/vkd3d-shader/hlsl_constant_ops.c
index 41a72ab6..28df074d 100644
--- a/libs/vkd3d-shader/hlsl_constant_ops.c
+++ b/libs/vkd3d-shader/hlsl_constant_ops.c
@@ -1008,7 +1008,7 @@ bool hlsl_fold_constant_exprs(struct hlsl_ctx *ctx, struct hlsl_ir_node *instr,
 
 bool hlsl_fold_constant_swizzles(struct hlsl_ctx *ctx, struct hlsl_ir_node *instr, void *context)
 {
-    struct hlsl_constant_value value;
+    struct hlsl_constant_value value = {};
     struct hlsl_ir_swizzle *swizzle;
     struct hlsl_ir_constant *src;
     struct hlsl_ir_node *dst;
-- 
GitLab

https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/308