Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.

[Jinoh Kang (＠iamahuman)]

Jinoh Kang (@iamahuman) commented about dlls/ntdll/unix/file.c:
> */
>  NTSTATUS WINAPI NtCancelSynchronousIoFile( HANDLE handle, IO_STATUS_BLOCK *io, IO_STATUS_BLOCK *io_status )
>  {
> -    FIXME( "(%p,%p,%p) stub\n", handle, io, io_status );
> -    return STATUS_NOT_IMPLEMENTED;
> +    NTSTATUS status;
> +
> +    TRACE( "(%p %p %p)\n", handle, io, io_status );
> I'd at least leave a "partial fixme" here, since this is, after all, a partial implementation.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3835

[PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.

[Zebediah Figura]

On 7/10/22 12:41, Jinoh Kang (@iamahuman) wrote:
> Jinoh Kang (@iamahuman) commented about dlls/ntdll/unix/file.c:
> > */
> >   NTSTATUS WINAPI NtCancelSynchronousIoFile( HANDLE handle, IO_STATUS_BLOCK *io, IO_STATUS_BLOCK *io_status )
> >   {
> > -    FIXME( "(%p,%p,%p) stub\n", handle, io, io_status );
> > -    return STATUS_NOT_IMPLEMENTED;
> > +    NTSTATUS status;
> > +
> > +    TRACE( "(%p %p %p)\n", handle, io, io_status );
> > I'd at least leave a "partial fixme" here, since this is, after all, a partial implementation.

Wait, what's partial about it?