[PATCH 0/1] MR1581: include: Annotate StrDup[AW] with __WINE_MALLOC and __WINE_DEALLOC.

[Alex Henrie (＠alexhenrie)]

This gets us a nice warning if a string allocated by one of these functions is freed incorrectly.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1581

[PATCH 1/1] include: Annotate StrDup[AW] with __WINE_MALLOC and __WINE_DEALLOC.

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

---
 include/shlwapi.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/shlwapi.h b/include/shlwapi.h
index 6149c7081a3..cfebe238615 100644
--- a/include/shlwapi.h
+++ b/include/shlwapi.h
@@ -838,8 +838,8 @@ INT WINAPI StrCmpNIW(LPCWSTR,LPCWSTR,INT);
 #define StrCmpNI WINELIB_NAME_AW(StrCmpNI)
 #define StrNCmpI WINELIB_NAME_AW(StrCmpNI)
 
-LPSTR WINAPI StrDupA(LPCSTR);
-LPWSTR WINAPI StrDupW(LPCWSTR);
+char * WINAPI StrDupA(const char *) __WINE_DEALLOC(LocalFree) __WINE_MALLOC;
+WCHAR * WINAPI StrDupW(const WCHAR *) __WINE_DEALLOC(LocalFree) __WINE_MALLOC;
 #define StrDup WINELIB_NAME_AW(StrDup)
 
 HRESULT WINAPI SHStrDupA(LPCSTR,WCHAR**);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1581

[PATCH 1/1] include: Annotate StrDup[AW] with __WINE_MALLOC and __WINE_DEALLOC.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=126899

Your paranoid android.


=== debian11 (32 bit report) ===

wldap32:
parse.c:245: Test failed: ldap_get_next_page_s failed 0x51
parse.c:246: Test failed: expected res != NULL
parse.c:247: Test failed: got 3735928559
Unhandled exception: page fault on read access to 0x0000001c in 32-bit code (0x6f8d7bce).