[PATCH 0/1] MR8597: winex11.drv: Implement WS_EX_TRANSPARENT mouse pass-through with ShapeInput extension
- Add sync_window_input_shape() function to handle ShapeInput operations - Modify get_window_attributes() to exclude mouse events for transparent windows - Update sync_window_style() to call sync_window_input_shape() - Handle WS_EX_TRANSPARENT style changes in X11DRV_SetWindowStyle() - Ensure proper input shape setup in create_whole_window() This implementation uses both event mask control and ShapeInput extension to provide accurate mouse pass-through functionality for windows with WS_EX_TRANSPARENT extended style. When a window has this style, mouse events will pass through to underlying windows while still allowing keyboard and focus events. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8597
From: Jiajin Cui <cuijiajin(a)uniontech.com> - Add sync_window_input_shape() function to handle ShapeInput operations - Modify get_window_attributes() to exclude mouse events for transparent windows - Update sync_window_style() to call sync_window_input_shape() - Handle WS_EX_TRANSPARENT style changes in X11DRV_SetWindowStyle() - Ensure proper input shape setup in create_whole_window() This implementation uses both event mask control and ShapeInput extension to provide accurate mouse pass-through functionality for windows with WS_EX_TRANSPARENT extended style. When a window has this style, mouse events will pass through to underlying windows while still allowing keyboard and focus events. --- dlls/winex11.drv/window.c | 78 +++++++++++++++++++++++++++++++++++---- 1 file changed, 70 insertions(+), 8 deletions(-) diff --git a/dlls/winex11.drv/window.c b/dlls/winex11.drv/window.c index b9055791a60..700a8b3bd41 100644 --- a/dlls/winex11.drv/window.c +++ b/dlls/winex11.drv/window.c @@ -487,21 +487,67 @@ static unsigned long get_mwm_decorations( struct x11drv_win_data *data, DWORD st */ static int get_window_attributes( struct x11drv_win_data *data, XSetWindowAttributes *attr ) { + DWORD ex_style = NtUserGetWindowLongW( data->hwnd, GWL_EXSTYLE ); + attr->colormap = data->whole_colormap ? data->whole_colormap : default_colormap; attr->save_under = ((NtUserGetClassLongW( data->hwnd, GCL_STYLE ) & CS_SAVEBITS) != 0); attr->bit_gravity = NorthWestGravity; attr->backing_store = NotUseful; attr->border_pixel = 0; attr->background_pixel = 0; - attr->event_mask = (ExposureMask | PointerMotionMask | - ButtonPressMask | ButtonReleaseMask | EnterWindowMask | - KeyPressMask | KeyReleaseMask | FocusChangeMask | - KeymapStateMask | StructureNotifyMask | PropertyChangeMask); + + /* Set event mask based on WS_EX_TRANSPARENT style */ + if (ex_style & WS_EX_TRANSPARENT) + { + /* For transparent windows, exclude mouse events to allow mouse pass-through */ + attr->event_mask = (ExposureMask | KeyPressMask | KeyReleaseMask | + FocusChangeMask | KeymapStateMask | StructureNotifyMask | PropertyChangeMask); + } + else + { + /* Normal event mask including mouse events */ + attr->event_mask = (ExposureMask | PointerMotionMask | + ButtonPressMask | ButtonReleaseMask | EnterWindowMask | + KeyPressMask | KeyReleaseMask | FocusChangeMask | + KeymapStateMask | StructureNotifyMask | PropertyChangeMask); + } return (CWSaveUnder | CWColormap | CWBorderPixel | CWBackPixel | CWEventMask | CWBitGravity | CWBackingStore); } +/*********************************************************************** + * sync_window_input_shape + * + * Update the X11 window input shape for WS_EX_TRANSPARENT windows. + * This uses the ShapeInput extension to control which areas of the window + * can receive input events. + */ +static void sync_window_input_shape( struct x11drv_win_data *data ) +{ +#ifdef HAVE_LIBXSHAPE + DWORD ex_style = NtUserGetWindowLongW( data->hwnd, GWL_EXSTYLE ); + + if (!data->whole_window) return; + + if (ex_style & WS_EX_TRANSPARENT) + { + /* For transparent windows, set an empty input shape to allow mouse pass-through */ + static XRectangle empty_rect; + XShapeCombineRectangles( data->display, data->whole_window, ShapeInput, 0, 0, + &empty_rect, 1, ShapeSet, YXBanded ); + TRACE( "window %p/%lx set empty input shape for WS_EX_TRANSPARENT\n", + data->hwnd, data->whole_window ); + } + else + { + /* For normal windows, reset input shape to default (full window) */ + XShapeCombineMask( data->display, data->whole_window, ShapeInput, 0, 0, None, ShapeSet ); + TRACE( "window %p/%lx reset input shape to default\n", + data->hwnd, data->whole_window ); + } +#endif +} /*********************************************************************** * sync_window_style @@ -519,6 +565,9 @@ static void sync_window_style( struct x11drv_win_data *data ) data->whole_window, mask, NextRequest( data->display ) ); XChangeWindowAttributes( data->display, data->whole_window, mask, &attr ); x11drv_xinput2_enable( data->display, data->whole_window ); + + /* Sync input shape for WS_EX_TRANSPARENT windows */ + sync_window_input_shape( data ); } } @@ -2395,6 +2444,9 @@ static void create_whole_window( struct x11drv_win_data *data ) if (!NtUserGetLayeredWindowAttributes( data->hwnd, &key, &alpha, &layered_flags )) layered_flags = 0; sync_window_opacity( data->display, data->whole_window, alpha, layered_flags ); + /* set the input shape for WS_EX_TRANSPARENT windows */ + sync_window_input_shape( data ); + XFlush( data->display ); /* make sure the window exists before we start painting to it */ done: @@ -2520,11 +2572,21 @@ void X11DRV_SetWindowStyle( HWND hwnd, INT offset, STYLESTRUCT *style ) if (offset == GWL_STYLE && (changed & WS_DISABLED)) set_wm_hints( data ); - if (offset == GWL_EXSTYLE && (changed & WS_EX_LAYERED)) /* changing WS_EX_LAYERED resets attributes */ + if (offset == GWL_EXSTYLE) { - data->layered = FALSE; - set_window_visual( data, &default_visual, FALSE ); - sync_window_opacity( data->display, data->whole_window, 0, 0 ); + if (changed & WS_EX_LAYERED) /* changing WS_EX_LAYERED resets attributes */ + { + data->layered = FALSE; + set_window_visual( data, &default_visual, FALSE ); + sync_window_opacity( data->display, data->whole_window, 0, 0 ); + } + + /* Handle WS_EX_TRANSPARENT style changes */ + if (changed & WS_EX_TRANSPARENT) + { + TRACE( "window %p WS_EX_TRANSPARENT style changed, syncing window attributes\n", hwnd ); + sync_window_style( data ); + } } done: release_win_data( data ); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/8597
[test_transparent.c](/uploads/7b601a28170159209e13deb23b8a8c1f/test_transparent.c) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8597#note_110273
participants (2)
-
Jiajin Cui -
Jiajin Cui (＠jin-king1)