[PATCH 0/1] MR4929: ntdll: Reduce fixme logging for large numbers of cores.

[Martin Storsjö]

Once we've reached the condition for skipping a core, we will
skip all other cores in the same range as well - don't print
a fixme message for each of them.

Signed-off-by: Martin Storsjö <martin(a)martin.st>

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4929

[PATCH 1/1] ntdll: Reduce fixme logging for large numbers of cores.

[Martin Storsjö]

From: Martin Storsjö <martin(a)martin.st>

Once we've reached the condition for skipping a core, we will
skip all other cores in the same range as well - don't print
a fixme message for each of them.

Signed-off-by: Martin Storsjö <martin(a)martin.st>
---
 dlls/ntdll/unix/system.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/ntdll/unix/system.c b/dlls/ntdll/unix/system.c
index e55ec9e1137..00eaf52fcce 100644
--- a/dlls/ntdll/unix/system.c
+++ b/dlls/ntdll/unix/system.c
@@ -933,8 +933,8 @@ static NTSTATUS create_logical_proc_info(void)
 
             if (i > 8 * sizeof(ULONG_PTR))
             {
-                FIXME("skipping logical processor %d\n", i);
-                continue;
+                FIXME("skipping logical processor %d up to %d\n", i, end);
+                break;
             }
 
             snprintf(name, sizeof(name), core_info, i, "physical_package_id");
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4929

[Martin Storsjö]

Martin Storsjö (@mstorsjo) commented about dlls/ntdll/unix/system.c:
> if (i > 8 * sizeof(ULONG_PTR))
>              {
> -                FIXME("skipping logical processor %d\n", i);
> -                continue;
> +                FIXME("skipping logical processor %d up to %d\n", i, end);

Alternatively, perhaps this `FIXME()` message could be skipped altogether (or demoted to a `TRACE()`?), as there's another message right above, on line 914, `FIXME("Improve CPU info reporting: system supports %u logical cores, but only %u supported!\n", max_cpus, MAXIMUM_PROCESSORS);`, which also triggers in the same cases.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4929#note_58816