[PATCH v3 0/1] MR8808: winealsa: Fixed MIDI reset Control Change

[Keigo Okamoto (＠KeigoOkamoto)]

This pull request fixes Wine's MIDI synthesizer reset process to be the same as Windows'.

When playing Touhou Project games in MIDI BGM mode, the music playback becomes buggy when the BGM changes.  
The video below is an example of an anomaly that occurs when playing The Fantastic Tales from Tono after playing Crystallized Silver in Touhou 7.  
https://youtu.be/O69sndJ45Ag

Here's a correct example of The Fantastic Tales from Tono playback:  
https://youtu.be/XlFAQEbbNDg

Piano sound is clearly missing on Wine.  
This issue occurs due to an Wine's incorrect reset process for MIDI synthesizer.

When I ran FluidSynth on Windows and checked the log, I found that CC123 and CC121 were executed for each MIDI channel when switching songs.  
CC123 means All Notes Off, CC121 means Reset All Controllers.

--
  v3: winealsa: Send All Notes Off and Reset Controllers.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8808

[PATCH v3 1/1] winealsa: Send All Notes Off and Reset Controllers.

[Keigo Okamoto]

From: Keigo Okamoto <reimu(a)hakurei.win>

---
 dlls/winealsa.drv/alsamidi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/winealsa.drv/alsamidi.c b/dlls/winealsa.drv/alsamidi.c
index fbc65bd95d1..efd35e6628c 100644
--- a/dlls/winealsa.drv/alsamidi.c
+++ b/dlls/winealsa.drv/alsamidi.c
@@ -945,9 +945,9 @@ static UINT midi_out_reset(WORD dev_id)
     for (chn = 0; chn < 16; chn++)
     {
         /* turn off every note */
-        midi_out_data(dev_id, (MIDI_CTL_ALL_SOUNDS_OFF << 8) | MIDI_CMD_CONTROL | chn);
-        /* remove sustain on all channels */
-        midi_out_data(dev_id, (MIDI_CTL_SUSTAIN << 8) | MIDI_CMD_CONTROL | chn);
+        midi_out_data(dev_id, (MIDI_CTL_ALL_NOTES_OFF << 8) | MIDI_CMD_CONTROL | chn);
+        /* resets controller settings */
+        midi_out_data(dev_id, (MIDI_CTL_RESET_CONTROLLERS << 8) | MIDI_CMD_CONTROL | chn);
     }
     dests[dev_id].runningStatus = 0;
     /* FIXME: the LongData buffers must also be returned to the app */
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/8808