[PATCH 0/1] MR5309: advapi32: Add todo_wine to tests that are currently failing.
The commit adds a todo_wine statement to the tests that are currently failing on my macOS build. The failing tests are in a conditional statement and the same tests in the `else` block already contain a `todo_wine` (see lines 8566 and 8571). My guess is, that on most systems, the `else` block is executed and the `todo_wine` was just forgotten in the `else if` statement. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5309
From: Noah Berner <noah(a)berner.io> --- dlls/advapi32/tests/security.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/advapi32/tests/security.c b/dlls/advapi32/tests/security.c index e2823fea63a..2669c13748b 100644 --- a/dlls/advapi32/tests/security.c +++ b/dlls/advapi32/tests/security.c @@ -8502,12 +8502,12 @@ static void test_elevation(void) type = TokenElevationTypeLimited; ret = SetTokenInformation(token, TokenElevationType, &type, sizeof(type)); ok(!ret, "expected failure\n"); - ok(GetLastError() == ERROR_INVALID_PARAMETER, "got error %lu\n", GetLastError()); + todo_wine ok(GetLastError() == ERROR_INVALID_PARAMETER, "got error %lu\n", GetLastError()); elevation.TokenIsElevated = FALSE; ret = SetTokenInformation(token, TokenElevation, &elevation, sizeof(elevation)); ok(!ret, "expected failure\n"); - ok(GetLastError() == ERROR_INVALID_PARAMETER, "got error %lu\n", GetLastError()); + todo_wine ok(GetLastError() == ERROR_INVALID_PARAMETER, "got error %lu\n", GetLastError()); } else { -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/5309
participants (2)
-
Noah Berner -
Noah Berner (@nberner)