[PATCH 0/1] MR989: d3d10core/tests: Mark tests failing randomly on Windows as flaky.
From: Francois Gouget <fgouget(a)codeweavers.com> Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=53252 --- dlls/d3d10core/tests/d3d10core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/d3d10core/tests/d3d10core.c b/dlls/d3d10core/tests/d3d10core.c index 74f689630eb..f1c5c0ebd8c 100644 --- a/dlls/d3d10core/tests/d3d10core.c +++ b/dlls/d3d10core/tests/d3d10core.c @@ -4678,6 +4678,7 @@ static void test_occlusion_query(void) ID3D10Asynchronous_End(query); get_query_data(query, &data, sizeof(data)); + flaky ok(data.uint == 640 * 480, "Got unexpected query result 0x%08x%08x.\n", data.dword[1], data.dword[0]); memset(&data, 0xff, sizeof(data)); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/989
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=124686 Your paranoid android. === w1064 (64 bit report) === d3d10core: d3d10core.c:4682: Test marked flaky: Got unexpected query result 0x0000000000000000. Report validation errors: d3d10core:d3d10core has unaccounted for failure messages d3d10core:d3d10core returned success despite having failures
On 10/1/22 07:05, Francois Gouget wrote:
From: Francois Gouget <fgouget(a)codeweavers.com>
Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=53252 --- dlls/d3d10core/tests/d3d10core.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/dlls/d3d10core/tests/d3d10core.c b/dlls/d3d10core/tests/d3d10core.c index 74f689630eb..f1c5c0ebd8c 100644 --- a/dlls/d3d10core/tests/d3d10core.c +++ b/dlls/d3d10core/tests/d3d10core.c @@ -4678,6 +4678,7 @@ static void test_occlusion_query(void)
ID3D10Asynchronous_End(query); get_query_data(query, &data, sizeof(data)); + flaky ok(data.uint == 640 * 480, "Got unexpected query result 0x%08x%08x.\n", data.dword[1], data.dword[0]);
memset(&data, 0xff, sizeof(data));
This is probably the same WARP bug as d741742e3. My inclination would be to do the same thing here.
This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/989
This should hopefully be addressed by <https://source.winehq.org/git/wine.git/commitdiff/2763e5b70ffad52cd8ec8a227890a009ea8fc51d>. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/989#note_28386
This merge request was closed by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/989
participants (6)
-
Francois Gouget -
Francois Gouget (＠fgouget)
-
Jan Sikorski (＠jsikorski)
-
Marvin -
Zebediah Figura -
Zebediah Figura (＠zfigura)