[PATCH 0/1] MR7494: msxml3: IXMLDOMDocument3::preserveWhiteSpace fix for a non VARIANT_BOOL value.

[Alistair Leslie-Hughes (＠alesliehughes)]

0024:trace:msxml:domdoc_put_preserveWhiteSpace (068F0520)->(1)

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=21940

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7494

[PATCH 1/1] msxml3: IXMLDOMDocument3::preserveWhiteSpace fix for a non VARIANT_BOOL value.

[Alistair Leslie-Hughes]

From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>

0024:trace:msxml:domdoc_put_preserveWhiteSpace (068F0520)->(1)

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=21940
---
 dlls/msxml3/domdoc.c       | 2 +-
 dlls/msxml3/tests/domdoc.c | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/dlls/msxml3/domdoc.c b/dlls/msxml3/domdoc.c
index 8407f914c4f..e1e8e6c803f 100644
--- a/dlls/msxml3/domdoc.c
+++ b/dlls/msxml3/domdoc.c
@@ -2746,7 +2746,7 @@ static HRESULT WINAPI domdoc_put_preserveWhiteSpace(
 {
     domdoc *This = impl_from_IXMLDOMDocument3( iface );
     TRACE("(%p)->(%d)\n", This, isPreserving);
-    This->properties->preserving = isPreserving;
+    This->properties->preserving = isPreserving == VARIANT_TRUE ? VARIANT_TRUE : VARIANT_FALSE;
     return S_OK;
 }
 
diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c
index 76f0c827c2a..3d0e361ee59 100644
--- a/dlls/msxml3/tests/domdoc.c
+++ b/dlls/msxml3/tests/domdoc.c
@@ -4925,6 +4925,12 @@ static void test_whitespace(void)
         IXMLDOMNodeList_Release(list);
         IXMLDOMElement_Release(root);
 
+        hr = IXMLDOMDocument2_put_preserveWhiteSpace(doc1, 1);
+        ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+        hr = IXMLDOMDocument2_get_preserveWhiteSpace(doc1, &b);
+        ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+        ok(b == VARIANT_FALSE, "expected true %d\n", b);
+
         IXMLDOMDocument2_Release(doc1);
 
         free_bstrs();
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/7494

[Nikolay Sivov (＠nsivov)]

Could you add a test to test_whitespace() as well, to see if out of range values do, if "1" means preserved or ignored.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7494#note_96912