[PATCH v2 0/1] MR9117: gdi32: Add stub for GetEnhMetaFilePixelFormat.

[Louis Lenders (＠xe)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58747

--
  v2: gdi32: Add stub for GetEnhMetaFilePixelFormat.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9117

[PATCH v2 1/1] gdi32: Add stub for GetEnhMetaFilePixelFormat.

[Louis Lenders]

From: Louis Lenders <xerox.xerox2000x(a)gmail.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58747

v2: Improve FIXME and return value.
---
 dlls/gdi32/enhmetafile.c | 9 +++++++++
 dlls/gdi32/gdi32.spec    | 2 +-
 include/wingdi.h         | 1 +
 3 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/dlls/gdi32/enhmetafile.c b/dlls/gdi32/enhmetafile.c
index 89622ef1b58..05db098afcd 100644
--- a/dlls/gdi32/enhmetafile.c
+++ b/dlls/gdi32/enhmetafile.c
@@ -3001,3 +3001,12 @@ end:
     DeleteMetaFile(hmf);
     return ret;
 }
+
+/******************************************************************
+ *         GetEnhMetaFilePixelFormat   (GDI32.@)
+ */
+UINT WINAPI GetEnhMetaFilePixelFormat( HENHMETAFILE hemf, UINT size, PIXELFORMATDESCRIPTOR *ppfd )
+{
+    FIXME( "(%p,%u,%p) stub\n", hemf, size, ppfd );
+    return GDI_ERROR;
+}
diff --git a/dlls/gdi32/gdi32.spec b/dlls/gdi32/gdi32.spec
index ae097e607ba..f51931f530a 100644
--- a/dlls/gdi32/gdi32.spec
+++ b/dlls/gdi32/gdi32.spec
@@ -375,7 +375,7 @@
 @ stdcall GetEnhMetaFileDescriptionW(long long ptr)
 @ stdcall GetEnhMetaFileHeader(long long ptr)
 @ stdcall GetEnhMetaFilePaletteEntries(long long ptr)
-# @ stub GetEnhMetaFilePixelFormat
+@ stdcall GetEnhMetaFilePixelFormat(ptr long ptr)
 @ stdcall GetEnhMetaFileW(wstr)
 # @ stub GetFontAssocStatus
 @ stdcall GetFontData(long long long ptr long) NtGdiGetFontData
diff --git a/include/wingdi.h b/include/wingdi.h
index ed0e59462e9..559f659297f 100644
--- a/include/wingdi.h
+++ b/include/wingdi.h
@@ -3957,6 +3957,7 @@ WINGDIAPI UINT        WINAPI GetEnhMetaFileDescriptionW(HENHMETAFILE,UINT,LPWSTR
 #define                      GetEnhMetaFileDescription WINELIB_NAME_AW(GetEnhMetaFileDescription)
 WINGDIAPI UINT        WINAPI GetEnhMetaFileHeader(HENHMETAFILE,UINT,LPENHMETAHEADER);
 WINGDIAPI UINT        WINAPI GetEnhMetaFilePaletteEntries(HENHMETAFILE,UINT,LPPALETTEENTRY);
+WINGDIAPI UINT        WINAPI GetEnhMetaFilePixelFormat(HENHMETAFILE,UINT,PIXELFORMATDESCRIPTOR*);
 WINGDIAPI DWORD       WINAPI GetFontData(HDC,DWORD,DWORD,LPVOID,DWORD);
 WINGDIAPI DWORD       WINAPI GetFontLanguageInfo(HDC);
 WINGDIAPI DWORD       WINAPI GetFontUnicodeRanges(HDC,LPGLYPHSET);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/9117

[Huw Davies (＠huw)]

Huw Davies (@huw) commented about dlls/gdi32/gdi32.spec:
> @ stdcall GetEnhMetaFileDescriptionW(long long ptr)
>  @ stdcall GetEnhMetaFileHeader(long long ptr)
>  @ stdcall GetEnhMetaFilePaletteEntries(long long ptr)
> -# @ stub GetEnhMetaFilePixelFormat
> +@ stdcall GetEnhMetaFilePixelFormat(ptr long ptr)
@ stdcall GetEnhMetaFilePixelFormat(long long ptr)

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9117#note_118469

[Huw Davies (＠huw)]

Huw Davies (@huw) commented about dlls/gdi32/enhmetafile.c:
> DeleteMetaFile(hmf);
>      return ret;
>  }
> +
> +/******************************************************************
> + *         GetEnhMetaFilePixelFormat   (GDI32.@)
> + */
> +UINT WINAPI GetEnhMetaFilePixelFormat( HENHMETAFILE hemf, UINT size, PIXELFORMATDESCRIPTOR *ppfd )
> +{
> +    FIXME( "(%p,%u,%p) stub\n", hemf, size, ppfd );

Could we rename `ppfd` to something like `fmt`?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9117#note_118470