[PATCH 0/1] MR3501: msvcp120/tests: Use compare_uint() in compare_float() instead of abs().

[Jeffrey Smith (＠whydoubt)]

The result of abs(INT_MIN) is INT_MIN, which breaks the ulps comparison.

See also: https://gitlab.winehq.org/wine/vkd3d/-/commit/69ecfdfb

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3501

[PATCH 1/1] msvcp120/tests: Use compare_uint() in compare_float() instead of abs().

[Jeff Smith]

From: Jeff Smith <whydoubt(a)gmail.com>

The result of abs(INT_MIN) is INT_MIN, which breaks the ulps comparison.
---
 dlls/msvcp120/tests/msvcp120.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/dlls/msvcp120/tests/msvcp120.c b/dlls/msvcp120/tests/msvcp120.c
index 44c0a3f0fe0..060dda5b45f 100644
--- a/dlls/msvcp120/tests/msvcp120.c
+++ b/dlls/msvcp120/tests/msvcp120.c
@@ -187,6 +187,13 @@ enum file_type {
     type_unknown
 };
 
+static BOOL compare_uint(unsigned int x, unsigned int y, unsigned int max_diff)
+{
+    unsigned int diff = x > y ? x - y : y - x;
+
+    return diff <= max_diff;
+}
+
 static BOOL compare_float(float f, float g, unsigned int ulps)
 {
     int x = *(int *)&f;
@@ -197,10 +204,7 @@ static BOOL compare_float(float f, float g, unsigned int ulps)
     if (y < 0)
         y = INT_MIN - y;
 
-    if (abs(x - y) > ulps)
-        return FALSE;
-
-    return TRUE;
+    return compare_uint(x, y, ulps);
 }
 
 static char* (__cdecl *p_setlocale)(int, const char*);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/3501