Re: [PATCH v2 0/5] MR10208: winebth.sys part 15: Add support for reading/caching GATT characteristic values

[Elizabeth Figura (＠zfigura)]

On Sun Mar  1 11:59:02 2026 +0000, Vibhav Pant wrote:
> Characteristics are how most IO in BLE is done, so I wanted to minimize
> the roundtrips between PE and Unix as much as possible (given that the
> wineserver IPC already going to make this slow). Plus, from my
> understanding, most GATT services tend to limit the size of the values
> to the default MTU (23 or so bytes). This way, most value reads should
> be happening inline anyway.
> This, and a lot of things honestly, seem like premature optimization. Even if the cost of a Unix call weren't already small in comparison with the server I/O, or indeed the actual hardware I/O, I think it'd still be a mistake to be adding extra code to optimize before we have any evidence it matters.

Same sort of thing about splitting up all the locks, which I've already talked about. It seems unlikely we need more than one; we don't _know_ we need more than one, and the extra complexity just makes things harder and risks deadlocks.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10208#note_130970