[PATCH 0/1] MR7153: msvcrt: fixed potential syntax misprint - Wine-gitlab - list.winehq.org

newer
[PATCH 0/1] MR7109: Added missing...

[PATCH 0/1] MR7153: msvcrt: fixed potential syntax misprint

older
Re: [PATCH v4 0/4] MR5830: dxgi:...

Herman Semenov (＠GermanAizek)

18 Jan 2025 18 Jan '25

10:06 p.m.

Is this a mistake? are the brackets very strangely located, or was the condition accidentally deleted there? Maybe legacy code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7153

Reply

Sign in to reply online Use email software

Show replies by date

Herman Semenov

18 Jan 18 Jan

10:06 p.m.

New subject: [PATCH 1/1] msvcrt: fixed potential syntax misprint

From: Herman Semenov <GermanAizek(a)yandex.ru> --- dlls/msvcrt/undname.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/msvcrt/undname.c b/dlls/msvcrt/undname.c index 923ec67d363..d76737e875c 100644 --- a/dlls/msvcrt/undname.c +++ b/dlls/msvcrt/undname.c @@ -197,8 +197,9 @@ static BOOL str_array_push(struct parsed_symbol* sym, const char* ptr, int len, assert(a->elts[a->num]); memcpy(a->elts[a->num], ptr, len); a->elts[a->num][len] = '\0'; - if (++a->num >= a->max) a->max = a->num; + if (++a->num >= a->max) { + a->max = a->num; int i; char c; -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/7153

Reply

Sign in to reply online Use email software

Marvin

10:37 p.m.

New subject: [PATCH 1/1] msvcrt: fixed potential syntax misprint

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=150936 Your paranoid android. === debian11b (64 bit WoW report) === mf: mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8. mf.c:6525: Test failed: Test 2: WaitForSingleObject returned 258 mf.c:6525: Test failed: Test 2: Unexpected hr 0xd36d8.

Reply

Sign in to reply online Use email software

Piotr Caban (＠piotr)

19 Jan 19 Jan

6:44 a.m.

Piotr Caban (@piotr) commented about dlls/msvcrt/undname.c:

assert(a->elts[a->num]); memcpy(a->elts[a->num], ptr, len); a->elts[a->num][len] = '\0'; - if (++a->num >= a->max) a->max = a->num; + if (++a->num >= a->max) { + a->max = a->num;

```suggestion:-2+0 if (++a->num >= a->max) a->max = a->num; if (TRACE_ON(msvcrt)) { ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7153#note_92178

Reply

Sign in to reply online Use email software

410

Age (days ago)

411

Last active (days ago)

Download

3 comments

4 participants

tags

participants (4)

Herman Semenov
Herman Semenov (＠GermanAizek)
Marvin
Piotr Caban (＠piotr)