Re: [PATCH v4 0/2] MR787: notepad: Add status bar and goto line dialog
7 Sep
2022
7 Sep
'22
1:06 p.m.
Generally I think this MR should be split into two separate ones. That'll give us a chance to get the status bar work in before we worry about the goto dialog box. So, just concentrating on the status bar commit, I'd start off by splitting that into two commits. First add the code that creates and displays the status bar (it doesn't need to display any text at this point). Then add a second commit that updates the status bar with line / col info. As @besentv mentioned, the commit messages are still not quite there - we terminate the subject with a period. I'll comment on some of the code below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/787#note_7869
1201
Age (days ago)
1201
Last active (days ago)
0 comments
1 participants
participants (1)
-
Huw Davies (@huw)