[PATCH 0/1] MR9629: configure: Add option for building with split debug info.

[Yuxuan Shui (＠yshui)]

* * *

all the machinery for split debug info is there, and the only thing needed is just exposing a flag from `configure`.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9629

[PATCH 1/1] configure: Add option for building with split debug info.

[Yuxuan Shui]

From: Yuxuan Shui <yshui(a)codeweavers.com>

---
 configure    | 9 +++++++++
 configure.ac | 2 ++
 2 files changed, 11 insertions(+)

diff --git a/configure b/configure
index 01538eefdc2..6aa47dae22e 100755
--- a/configure
+++ b/configure
@@ -920,6 +920,7 @@ enable_win16
 enable_win64
 enable_tests
 enable_build_id
+enable_split_debug
 enable_maintainer_mode
 enable_sast
 enable_silent_rules
@@ -2541,6 +2542,7 @@ Optional Features:
                           binaries)
   --disable-tests         do not build the regression tests
   --enable-build-id       include .buildid section in output objects
+  --enable-split-debug    enable split debug info
   --enable-maintainer-mode
                           enable maintainer-specific build rules
   --enable-sast           enable static application security testing using
@@ -4287,6 +4289,12 @@ then :
   enableval=$enable_build_id;
 fi
 
+# Check whether --enable-split-debug was given.
+if test ${enable_split_debug+y}
+then :
+  enableval=$enable_split_debug;
+fi
+
 # Check whether --enable-maintainer-mode was given.
 if test ${enable_maintainer_mode+y}
 then :
@@ -9495,6 +9503,7 @@ fi } ;;
         esac
       done
     fi
+    test "x$enable_split_debug" != xyes || as_fn_append wine_crossdebug " split"
     eval "${wine_arch}_DEBUG=\$wine_crossdebug"
 
     test "x$enable_werror" != xyes || { as_ac_var=`printf "%s\n" "ac_cv_${wine_arch}_cflags_-Werror" | sed "$as_sed_sh"`
diff --git a/configure.ac b/configure.ac
index 06a3a820e4c..490a5a7f416 100644
--- a/configure.ac
+++ b/configure.ac
@@ -21,6 +21,7 @@ AC_ARG_ENABLE(win16, AS_HELP_STRING([--disable-win16],[do not include Win16 supp
 AC_ARG_ENABLE(win64, AS_HELP_STRING([--enable-win64],[build a Win64 emulator on AMD64 (won't run Win32 binaries)]))
 AC_ARG_ENABLE(tests, AS_HELP_STRING([--disable-tests],[do not build the regression tests]))
 AC_ARG_ENABLE(build-id, AS_HELP_STRING([--enable-build-id],[include .buildid section in output objects]))
+AC_ARG_ENABLE(split-debug, AS_HELP_STRING([--enable-split-debug],[enable split debug info]))
 AC_ARG_ENABLE(maintainer-mode, AS_HELP_STRING([--enable-maintainer-mode],[enable maintainer-specific build rules]))
 AC_ARG_ENABLE(sast,  AS_HELP_STRING([--enable-sast],[enable static application security testing using Clang]))
 AC_ARG_ENABLE(silent-rules, AS_HELP_STRING([--enable-silent-rules],[use silent build rules (override: "make V=1")]))
@@ -626,6 +627,7 @@ This is an error since --enable-archs=$wine_arch was requested.])])
         esac
       done
     fi
+    test "x$enable_split_debug" != xyes || AS_VAR_APPEND(wine_crossdebug, " split")
     AS_VAR_SET([${wine_arch}_DEBUG],[$wine_crossdebug])
 
     test "x$enable_werror" != xyes || WINE_TRY_PE_CFLAGS([-Werror])
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/9629

[Yuxuan Shui (＠yshui)]

main motivation for this is, without split debug, 32-bit debug build is so big it sometimes make allocation fail.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9629#note_124259

[Jacek Caban (＠jacek)]

> all the machinery for split debug info is there, and the only thing needed is just exposing a flag from `configure`.

FWIW, you can just do `./configure CROSSDEBUG=split`. While I generally don't mind adding flags if people prefer them, it feels a bit arbitrary to add this one and not, for example, a PDB flag. I'd be also curious about the reason to prefer that flag over `CROSSDEBUG`.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9629#note_124304

[PATCH 0/1] MR9629: configure: Add option for building with split debug info. - closed

[Alexandre Julliard (＠julliard)]

This merge request was closed by Alexandre Julliard.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9629

[Alexandre Julliard (＠julliard)]

Doing this through `CROSSDEBUG` should be sufficient, it's not common enough to need a configure option.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9629#note_127096