Re: [PATCH v9 0/2] MR672: comdlg32: Common item dialog fixes

[Davide Beatrici (＠davidebeatrici)]

On Thu Aug 25 22:59:28 2022 +0000, Ben Cottrell wrote:
> I wish you had cut to the point. I'm closing this merge request for now,
> and reconsidering whether I should contribute again, because this has
> been more difficult than it should have been.
> What do you mean? A complex piece of software like this has rigid standards in order to prevent potential issues from arising, whether immediately or in the future.

I too made a few mistakes in my merge requests, but I have always taken the time to fix them and make things look nice. This is what improving is about.

Also, consider that generally the more reviewers the better:

- @julliard noticed that you changed the WinAPI definitions and explained that you cannot do that.
- @jhol spotted the icon issue.
- I tested your changes and reported back the results.

Imagine if this merge request was accepted as it was right at the beginning: guaranteed breakage.

If you deem your contribution(s) important to the project, please put on hold the MR until you have time to fix it.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/672#note_6968