[PATCH 0/27] MR26: vkd3d-shader/hlsl: Broaden resources support (draft).
This patch series has gotten quite big I don't expect this to be approved but I think it would be good if you review this approach so I start sending this patch series in fragments Because there are design decisions with long term effects Includes: * Many small fixes to corner cases I have stumbled upon. * For SM1, the tex2D and tex3D intrinsics, inferring generic samplers dimension from usage, writing sampler declarations, and writing sample instructions. * Support for arrays of resources for both SM1 and SM4. * Support for synthetic combined samplers for SM1 and synthetic separated samplers for SM4, considering that they can be arrays or members of other structs. All of this considering that the assignment of register indexes on allocation for each object component has to match match Some design changes are important in the long run Long reach of support to make sure this changes were in the right direction (I had to discard several approaches before reaching this one) Resource allocation is challenging because it is done at array level even if array is a member within a struct. because While I doubt this will be accepted quickly, I think it is a good thing Among the most complex things is ensuring that allocated I have tested with ps_3_0 and ps_5_0 These are some of the tests I have been running both for SM1 and SM4 (with -GeC) flag, so that the allocated registers matches the ones of the native compiler. [sm1-separated-samplers.hlsl](/uploads/5cfe4c4b64c208e3528c9b8e45959e0a/sm1-separated-samplers.hlsl) [sm1-separated-samplers-array.hlsl](/uploads/08734623aa930ec2f40f254824ffbb5b/sm1-separated-samplers-array.hlsl) [sm1-separated-samplers-2.hlsl](/uploads/32018666a2d4400f5fa8ec5f9edbac4d/sm1-separated-samplers-2.hlsl) [sm1-reserves-and-arrays.hlsl](/uploads/f8be8a59c818aea2ebc176d92b6de80d/sm1-reserves-and-arrays.hlsl) [sm1-reserves-and-dims.hlsl](/uploads/346087313ab21849ff20da3f9449b80f/sm1-reserves-and-dims.hlsl) [sm1-combined-order.hlsl](/uploads/4d77c5b68df1b365d4ec0a61d25e8d2d/sm1-combined-order.hlsl) [sm1-separated-and-combined-samplers.hlsl](/uploads/d9d337839642a29793358a86e31b8d40/sm1-separated-and-combined-samplers.hlsl) This patch series doesn't include these tests nor at automated way of testing them yet. -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/26
Ugh! I just pressed ctrl+enter by accident on this merge request in gitlab so it was sent while I was writing the text. (yep I write texts iteratively instead of sequentially). How frustrating... I will close it and send it again once I finish writing this properly. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/26#note_9889
This merge request was closed by Francisco Casas. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/26
participants (1)
-
Francisco Casas (＠fcasas)