[PATCH v5 0/1] MR3667: comctl32/status: Invalidate entire status bar on WM_SIZE.
Fixes a bug where the statusbar doesn't correctly paint when the parent window is resized. This can be seen in wine notepad. -- v5: comctl32/status: Invalidate entire status bar on WM_SIZE. https://gitlab.winehq.org/wine/wine/-/merge_requests/3667
From: Jacob Czekalla <jacobczekalla(a)gmail.com> --- dlls/comctl32/status.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/comctl32/status.c b/dlls/comctl32/status.c index 5251f3677b0..03ff689dfb1 100644 --- a/dlls/comctl32/status.c +++ b/dlls/comctl32/status.c @@ -1068,8 +1068,9 @@ STATUSBAR_WMSize (STATUS_INFO *infoPtr, WORD flags) width = parent_rect.right - parent_rect.left; x = parent_rect.left; y = parent_rect.bottom - infoPtr->height; - MoveWindow (infoPtr->Self, x, y, width, infoPtr->height, TRUE); + MoveWindow (infoPtr->Self, x, y, width, infoPtr->height, FALSE); STATUSBAR_SetPartBounds (infoPtr); + InvalidateRect(infoPtr->Self, NULL, FALSE); return TRUE; } -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/3667
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=136858 Your paranoid android. === debian11b (64 bit WoW report) === wsdapi: discovery.c:1085: Test failed: EndpointReference not received discovery.c:1086: Test failed: AppSequence not received discovery.c:1087: Test failed: MetadataVersion not received discovery.c:1088: Test failed: Hello message metadata not received discovery.c:1089: Test failed: Custom header not received discovery.c:1090: Test failed: Wine namespace not received discovery.c:1092: Test failed: Custom body element not received discovery.c:1093: Test failed: Types not received discovery.c:1094: Test failed: XML namespaces not received discovery.c:1095: Test failed: Scopes not received discovery.c:1096: Test failed: XAddrs not received
Did I just do something weird? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3667#note_43878
On Thu Aug 31 01:34:39 2023 +0000, Jacob Czekalla wrote:
Did I just do something weird? You pushed a wrong commit. It's fixed now.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3667#note_43924
Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/status.c:
width = parent_rect.right - parent_rect.left; x = parent_rect.left; y = parent_rect.bottom - infoPtr->height; - MoveWindow (infoPtr->Self, x, y, width, infoPtr->height, TRUE); + MoveWindow (infoPtr->Self, x, y, width, infoPtr->height, FALSE);
Let's remove the space after the function name MoveWindow. I know the style is not consistent. But let's make it so within a commit at least. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3667#note_43925
participants (4)
-
Jacob Czekalla -
Jacob Czekalla (＠Maaka00524)
-
Marvin -
Zhiyi Zhang (＠zhiyi)