[PATCH v9 0/1] MR9477: shell32: Implement the function PickIconDlg.
-- v9: shell32: Implement the function PickIconDlg https://gitlab.winehq.org/wine/wine/-/merge_requests/9477
From: Matthias Zorn <matthias0178@gmail.com> --- dlls/shell32/dialogs.c | 1254 ++++++++++++++++++++++++++++++++++++++- dlls/shell32/shell32.rc | 26 + dlls/shell32/shresdef.h | 18 + 3 files changed, 1295 insertions(+), 3 deletions(-) diff --git a/dlls/shell32/dialogs.c b/dlls/shell32/dialogs.c index 665c7093953..6ec6e316655 100644 --- a/dlls/shell32/dialogs.c +++ b/dlls/shell32/dialogs.c @@ -21,6 +21,7 @@ #include <string.h> #include <stdarg.h> #include <stdio.h> +#include <assert.h> #include "winerror.h" #include "windef.h" #include "winbase.h" @@ -72,17 +73,1264 @@ WINE_DEFAULT_DEBUG_CHANNEL(shell); static INT_PTR CALLBACK RunDlgProc (HWND, UINT, WPARAM, LPARAM) ; static void FillList (HWND, char *, BOOL) ; +#define IMAGE_LIST_INDEX_INVALID_VALUE -1 + +enum enumActionResult { eDoneSuccessfullyWithAcceptableConfirmation, eDoneSuccessfully, + eNotDoneNoError, eNotDoneErrorNotSerious, eNotDoneSeriousError }; + +static const WCHAR extended_length_path_prefix[] = { '\\', '\\', '?', '\\', 0 }; +static const WCHAR system_root_var[] = { '%', 'S', 'y', 's', 't', 'e', 'm', 'R', 'o', + 'o', 't', '%', 0 }; +static const WCHAR shell32_dll_file_name[] = { 'S', 'H', 'E', 'L', 'L', '3', '2', + '.', 'd', 'l', 'l', 0 }; +static const WCHAR file_extension_ico[] = { '.', 'i', 'c', 'o', 0 }; +static const WCHAR backslash_text[] = { '\\', 0 }; +static const WCHAR mask_integer[] = { '%', 'i', 0 }; +static const WCHAR trim_chars[] = { '"', '\t', ' ', 0 }; +static const WCHAR mask_s[] = { '%', 's', 0 }; + +struct tagIconNamesStruct +{ + union + { + INT index; + WCHAR *name; + } iconReferenceUnion; + BOOL icon_reference_to_index; + INT image_list_index; + struct tagIconNamesStruct *next; +}; + + +struct tag_IconDialogStruct +{ + HWND parent_of_pick_icon_dialog; + WCHAR *path_filename_allocated; + WCHAR *source_of_shown_icon_data; + UINT path_filename_max_chars; + UINT new_path_filename_max_length; + BOOL path_filename_changed_without_data_update; + BOOL bad_input_error_message_showed; + INT icon_index; + DWORD error_code; + BOOL ignore_notifications; + struct tagIconNamesStruct *first, *last; +}; + + +static BOOL PickIconDlg_ErrorCodeMeansSeriousError(const DWORD error_code) +{ + switch(error_code) + { + case ERROR_OUTOFMEMORY: + case ERROR_NOT_ENOUGH_MEMORY: + case ERROR_INTERNAL_ERROR: + case ERROR_MOD_NOT_FOUND: + case ERROR_PROC_NOT_FOUND: + case ERROR_DLL_INIT_FAILED: + return TRUE; + default: + return FALSE; + } +} + +/* + * In some scenarios, GetLastError() might work fine even if it is not documented by Microsoft. + */ +static DWORD GetUndocumentedLastError(VOID) +{ + DWORD return_value; + return_value = GetLastError(); + if(return_value == ERROR_SUCCESS) + return_value = ERROR_INTERNAL_ERROR; + return return_value; +} + + +static BOOL PickIconDlg_IsIcoFile(const WCHAR *path_filename) +{ + int text_length; + text_length = lstrlenW(path_filename); + if(text_length >= 4) + { + if(lstrcmpiW(&path_filename[text_length - 4], file_extension_ico) == 0) + return TRUE; + } + return FALSE; +} + + +static enum enumActionResult PickIconDlg_ClearIconsData(const HWND dialog) +{ + HWND control; + HIMAGELIST image_list; + BOOL deleted; + struct tagIconNamesStruct *current_record; + struct tag_IconDialogStruct *dialog_data = + (struct tag_IconDialogStruct *) GetWindowLongPtrW(dialog, DWLP_USER); + control = GetDlgItem(dialog, IDC_PICKICONDLG_ICONS); + current_record = dialog_data->first; + while (current_record != NULL) + { + struct tagIconNamesStruct *record_to_delete; + if(!current_record->icon_reference_to_index) + free(current_record->iconReferenceUnion.name); + record_to_delete = current_record; + current_record = current_record->next; + free(record_to_delete); + } + dialog_data->first = dialog_data->last = NULL; + deleted = SendMessageW(control, LVM_DELETEALLITEMS,(WPARAM) 0, (LPARAM) 0); + if(!deleted) + { + dialog_data->error_code = ERROR_INTERNAL_ERROR; + return eNotDoneSeriousError; + } + image_list = (HIMAGELIST) SendMessageW(control, LVM_SETIMAGELIST, (WPARAM)(0), + (LPARAM)(HIMAGELIST)(((void *) 0))); + if(image_list != NULL) + { + BOOL destroyed = ImageList_Destroy(image_list); + assert(destroyed); + } + free(dialog_data->source_of_shown_icon_data); + dialog_data->source_of_shown_icon_data = NULL; + return (dialog_data->error_code == ERROR_SUCCESS) ? eDoneSuccessfully : + eNotDoneSeriousError; +} + + +static WCHAR *PickIconDlg_CreateExpanded(const WCHAR *just_path_with_backslash_at_end, + const WCHAR *file_name) +{ + WCHAR *return_value, *unexpanded; + int length_path, length_file_name; + DWORD required_expanded_size, number; + length_path = lstrlenW(just_path_with_backslash_at_end); + length_file_name = lstrlenW(file_name); + unexpanded = malloc((length_path + length_file_name + 1) * sizeof(WCHAR)); + if(unexpanded == NULL) + return NULL; + lstrcpyW(unexpanded, just_path_with_backslash_at_end); + lstrcatW(unexpanded, file_name); + required_expanded_size = ExpandEnvironmentStringsW(unexpanded, NULL, 0); + return_value = malloc(required_expanded_size * sizeof(WCHAR)); + if(return_value == NULL) + { + free(unexpanded); + return NULL; + } + number = ExpandEnvironmentStringsW(unexpanded, return_value, + required_expanded_size); + if(number == 0) + { + if(return_value != NULL) + free(return_value); + return_value = NULL; + } + free(unexpanded); + return return_value; +} + + +static WCHAR *PickIconDlg_GetSystemDirectoryPathFilename(const WCHAR *file_name, + const BOOL with_extended_length_path_prefix, const BOOL use_environment_variable) +{ + DWORD chars_needed; + UINT size = GetSystemDirectoryW(NULL, 0); + UINT file_name_chars = lstrlenW(file_name); + WCHAR *buffer; + chars_needed = size + file_name_chars + 1; + if(with_extended_length_path_prefix) + chars_needed += 4; + buffer = malloc(chars_needed * sizeof(WCHAR)); + if(buffer != NULL) + { + if(!with_extended_length_path_prefix) + GetSystemDirectoryW(buffer, size); + else + { + lstrcpyW(buffer, extended_length_path_prefix); + GetSystemDirectoryW(&buffer[4], size); + } + lstrcatW(buffer, backslash_text); + lstrcatW(buffer, file_name); + if(use_environment_variable) + { + WCHAR *system_root_var_expanded; + DWORD result; + WCHAR *match; + DWORD index, system_root_var_expanded_chars; + DWORD buffer_chars, copy_bytes; + const DWORD system_root_var_size = ARRAYSIZE(system_root_var) - 1; + result = ExpandEnvironmentStringsW(system_root_var, NULL, 0); + system_root_var_expanded = malloc(result * sizeof(WCHAR)); + if(system_root_var_expanded == NULL) + { + free(buffer); + return NULL; + } + result = ExpandEnvironmentStringsW(system_root_var, system_root_var_expanded, + result * sizeof(WCHAR)); + assert(result > 0); + buffer_chars = lstrlenW(buffer); + CharUpperW(buffer); + CharUpperW(system_root_var_expanded); + match = wcsstr(buffer, system_root_var_expanded); + if(match == NULL) + { + free(system_root_var_expanded); + return buffer; + } + index = match - buffer; + system_root_var_expanded_chars = lstrlenW(system_root_var_expanded); + chars_needed = buffer_chars + system_root_var_size - + system_root_var_expanded_chars + 1; + if(chars_needed > buffer_chars) + { + WCHAR *buffer2 = (WCHAR *) realloc(buffer, chars_needed * sizeof(WCHAR)); + if(buffer2 == NULL) + { + if(buffer != NULL) free(buffer); + free(system_root_var_expanded); + return NULL; + } + buffer = buffer2; + } + copy_bytes = sizeof(WCHAR) * (buffer_chars - index - + system_root_var_expanded_chars + 1); + memmove(&buffer[index + system_root_var_size], + &buffer[index + system_root_var_expanded_chars], copy_bytes); + copy_bytes = system_root_var_size * sizeof(WCHAR); + memmove(&buffer[index], system_root_var, copy_bytes); + } + } + return buffer; +} + + +static WCHAR *PickIconDlg_CreateExpandedOrCompletedPathFileName(const WCHAR *path_elementname, + const BOOL with_extended_length_path_prefix) +{ + WCHAR *return_value; + if(PathIsFileSpecW(path_elementname)) + { + WCHAR path1[25]; + static const WCHAR back_slash[] = { '\\', 0 }; + path1[0] = 0; + if(with_extended_length_path_prefix) + lstrcatW(path1, extended_length_path_prefix); + lstrcatW(path1, system_root_var); + lstrcatW(path1, back_slash); + return_value = PickIconDlg_CreateExpanded(path1, path_elementname); + if(return_value) + if(GetFileAttributesW(return_value) == INVALID_FILE_ATTRIBUTES) + { + free(return_value); + return_value = + PickIconDlg_GetSystemDirectoryPathFilename(path_elementname, + with_extended_length_path_prefix, FALSE); + } + } + else + { + DWORD result; + result = ExpandEnvironmentStringsW(path_elementname, NULL, 0); + return_value = malloc((result + 4) * sizeof(WCHAR)); + if(return_value) + { + WCHAR *resolved = return_value; + int index; + if(with_extended_length_path_prefix) + lstrcpyW(resolved, extended_length_path_prefix); + index = with_extended_length_path_prefix ? 4 : 0; + result = ExpandEnvironmentStringsW(path_elementname, &resolved[index], + result * sizeof(WCHAR)); + assert(result > 0); + } + } + return return_value; +} + + +static enum enumActionResult PickIconDlg_UpdateImagesDataUseIcoFile(const HWND dialog, + const WCHAR *extended_length_path_filename) +{ + HICON icon; + HWND listview; + HIMAGELIST image_list = NULL; + INT index; + INT icon_size_y, icon_size_x; + UINT dpi; + enum enumActionResult result; + struct tag_IconDialogStruct *dialog_data = (VOID *) GetWindowLongPtrW(dialog, DWLP_USER); + assert(PickIconDlg_IsIcoFile(extended_length_path_filename)); + dpi = GetDpiForWindow(dialog); + icon_size_y = GetSystemMetricsForDpi(SM_CYICON, dpi); + icon_size_x = GetSystemMetricsForDpi(SM_CXICON, dpi); + assert(icon_size_x == icon_size_y); + icon = LoadImageW(NULL, extended_length_path_filename, IMAGE_ICON, icon_size_x, + icon_size_y, LR_LOADFROMFILE); + if(icon == NULL) + { + dialog_data->error_code = GetLastError(); + if(dialog_data->error_code == ERROR_SUCCESS) + dialog_data->error_code = ERROR_BAD_FORMAT; + PickIconDlg_ClearIconsData(dialog); + return PickIconDlg_ErrorCodeMeansSeriousError(dialog_data->error_code) ? + eNotDoneSeriousError : eNotDoneErrorNotSerious; + } + listview = GetDlgItem(dialog, IDC_PICKICONDLG_ICONS); + SendMessageW(listview, LVM_SETICONSPACING, 0, MAKELONG(icon_size_x * 14 / 10, + icon_size_y * 17 / 10)); + image_list = ImageList_Create(icon_size_x, icon_size_y, ILC_MASK | ILC_COLOR32, 1, 1); + if(image_list != NULL) + { + index = ImageList_ReplaceIcon(image_list, -1, icon); + if(index == -1) + dialog_data->error_code = ERROR_INTERNAL_ERROR; + } + else + dialog_data->error_code = GetUndocumentedLastError(); + if(!DestroyIcon(icon)) + { + if(dialog_data->error_code == ERROR_SUCCESS) + dialog_data->error_code = GetLastError(); + } + if(dialog_data->error_code == ERROR_SUCCESS) + { + HIMAGELIST old_image_list; + INT index; + LVITEMW lv = { 0 }; + static const WCHAR text_zero[] = { '0', 0 }; + result = PickIconDlg_ClearIconsData(dialog); + if(result != eDoneSuccessfully) + { + BOOL destroyed = ImageList_Destroy(image_list); + assert(destroyed); + return result; + } + old_image_list = (HIMAGELIST) SendMessageW(listview, LVM_SETIMAGELIST, + LVSIL_NORMAL, (LPARAM) (HIMAGELIST) image_list); + if(old_image_list != NULL) + { + BOOL successful = ImageList_Destroy(old_image_list); + assert(successful); + } + lv.mask = LVIF_IMAGE | LVIF_TEXT | LVIF_PARAM; + lv.iImage = 0; + lv.lParam = 0; + lv.pszText = (WCHAR *) text_zero; + index = SendMessageW(listview, LVM_INSERTITEMW, 0, (LPARAM) &lv); + if(index == -1) + dialog_data->error_code = ERROR_INTERNAL_ERROR; + } + if(dialog_data->error_code == ERROR_SUCCESS) + { + size_t struct_size; + struct_size = sizeof(struct tagIconNamesStruct); + dialog_data->first = dialog_data->last = malloc(struct_size); + if(dialog_data->first != NULL) + { + dialog_data->first->icon_reference_to_index = TRUE; + dialog_data->first->iconReferenceUnion.index = 0; + dialog_data->first->image_list_index = 0; + dialog_data->first->next = NULL; + } + else + dialog_data->error_code = ERROR_OUTOFMEMORY; + } + if(dialog_data->error_code == ERROR_SUCCESS) + return eDoneSuccessfully; + else + return PickIconDlg_ErrorCodeMeansSeriousError(dialog_data->error_code) ? + eNotDoneSeriousError : eNotDoneErrorNotSerious; +} + + +/* Should only be used when the icons in the listview are cleared. If the listview is assigned an + * image list, it will be replaced with a created new image list. + * The listview data chain (dialog_data->first) must be filled with the information which icons should + * be displayed in the list view. + * It updates the listview contents with and the icons in the module, and the listview will get a new + * image list. + * EnumResourceNames with LoadImageNames as parameter must be called before */ +/* returns FALSE if error occured, error code will be daved in dialog_data->error_code */ +static BOOL PickIconDlg_AddIconsToListViewUseLibrary(const HMODULE module, const HWND dialog) +{ + INT record_counter; + INT icon_size_y, icon_size_x; + HWND listview; + HIMAGELIST image_list, old_image_list; + LVITEMW lv = { 0 }; + UINT dpi; + struct tag_IconDialogStruct *dialog_data = (VOID *) GetWindowLongPtrW(dialog, DWLP_USER); + struct tagIconNamesStruct *current_icon_name = dialog_data->first; + dpi = GetDpiForWindow(dialog); + icon_size_y = GetSystemMetricsForDpi(SM_CYICON, dpi); + icon_size_x = GetSystemMetricsForDpi(SM_CXICON, dpi); + image_list = ImageList_Create(icon_size_x, icon_size_y, ILC_MASK | ILC_COLOR32, 1, 100); + if(image_list == NULL) + { + dialog_data->error_code = ERROR_INTERNAL_ERROR; + return FALSE; + } + listview = GetDlgItem(dialog, IDC_PICKICONDLG_ICONS); + while((current_icon_name != NULL) && (dialog_data->error_code == ERROR_SUCCESS)) + { + HICON icon; + if(current_icon_name->icon_reference_to_index) + icon = LoadImageW(module, (LPCWSTR) (INT_PTR) + current_icon_name->iconReferenceUnion.index, IMAGE_ICON, icon_size_x, + icon_size_y, 0); + else + icon = LoadImageW(module, current_icon_name->iconReferenceUnion.name, + IMAGE_ICON, icon_size_x, icon_size_y, 0); + if(icon == NULL) + { + dialog_data->error_code = GetLastError(); + if(dialog_data->error_code == ERROR_MOD_NOT_FOUND) /* if icon could not + be loaded because icon format was not OK */ + dialog_data->error_code = ERROR_SUCCESS; + } + else + { + current_icon_name->image_list_index = + ImageList_ReplaceIcon(image_list, -1, icon); + if(current_icon_name->image_list_index == -1) + dialog_data->error_code = ERROR_INTERNAL_ERROR; + if(!DestroyIcon(icon)) + { + if(dialog_data->error_code == ERROR_SUCCESS) + dialog_data->error_code = GetLastError(); + } + } + current_icon_name = current_icon_name->next; + } + if(dialog_data->error_code != ERROR_SUCCESS) + { + ImageList_Destroy(image_list); + return FALSE; + } +#ifndef LVS_EX_HIDELABELS_IMPLEMENTED + SendMessageW(listview, LVM_SETICONSPACING, 0, + (LPARAM) MAKELONG(icon_size_x * 14 / 10, icon_size_y * 17 / 10)); +#else + SendMessageW(listview, LVM_SETICONSPACING, 0, + (LPARAM) MAKELONG(icon_size_x * 12 / 10, icon_size_y * 12 / 10)); +#endif + old_image_list = (HIMAGELIST) SendMessageW(listview, LVM_SETIMAGELIST, LVSIL_NORMAL, + (LPARAM) image_list); + if(old_image_list != NULL) + { + BOOL successful = ImageList_Destroy(old_image_list); + assert(successful); + } + current_icon_name = dialog_data->first; + lv.mask = LVIF_IMAGE | LVIF_TEXT | LVIF_PARAM; + record_counter = 0; + while(current_icon_name != NULL) + { + if(current_icon_name->image_list_index != IMAGE_LIST_INDEX_INVALID_VALUE) + { + WCHAR buffer[15]; + INT index; + lv.iImage = current_icon_name->image_list_index; + lv.lParam = record_counter; + if(current_icon_name->icon_reference_to_index) + { + wsprintfW(buffer, mask_integer, current_icon_name->iconReferenceUnion.index); + lv.pszText = buffer; + } + else + lv.pszText = current_icon_name->iconReferenceUnion.name; + index = SendMessageW(listview, LVM_INSERTITEMW, 0, (LPARAM) &lv); + if(index == -1) + { + dialog_data->error_code = ERROR_INTERNAL_ERROR; + return FALSE; + } + lv.iItem++; + } + current_icon_name = current_icon_name->next; + record_counter++; + } + return TRUE; +} + + +/* returns false when allocation of memory failed */ +static BOOL CALLBACK PickIconDlg_LoadImageNames(HMODULE module, LPCWSTR type, LPWSTR name, + LONG_PTR lparam) +{ + struct tag_IconDialogStruct *dialog_data = (struct tag_IconDialogStruct *) lparam; + struct tagIconNamesStruct *icon_name = malloc(sizeof(*icon_name)); + (void) module; + (void) type; + if(icon_name == NULL) + { + dialog_data->error_code = ERROR_OUTOFMEMORY; + return FALSE; + } + icon_name->image_list_index = IMAGE_LIST_INDEX_INVALID_VALUE; + icon_name->icon_reference_to_index = IS_INTRESOURCE(name); + icon_name->next = NULL; + if(IS_INTRESOURCE(name)) + icon_name->iconReferenceUnion.index = (INT) (INT_PTR) name; + else + { + icon_name->iconReferenceUnion.name = malloc(sizeof(WCHAR) * (lstrlenW(name) + 1)); + if(icon_name->iconReferenceUnion.name == NULL) + { + free(icon_name); + dialog_data->error_code = ERROR_OUTOFMEMORY; + return FALSE; + } + lstrcpyW(icon_name->iconReferenceUnion.name, name); + } + if(dialog_data->first == NULL) + dialog_data->first = dialog_data->last = icon_name; + else + { + dialog_data->last->next = icon_name; + dialog_data->last = icon_name; + } + return TRUE; +} + + + +static enum enumActionResult PickIconDlg_UpdateImagesDataUseLibrary(const HWND dialog, + const WCHAR *extended_length_path_filename) +{ + HINSTANCE instance; + HWND control; + enum enumActionResult return_value; + BOOL update_successful; + struct tag_IconDialogStruct *dialog_data = (struct tag_IconDialogStruct *) + GetWindowLongPtrW(dialog, DWLP_USER); + control = GetDlgItem(dialog, IDC_PICKICONDLG_ICONS); + instance = LoadLibraryExW(extended_length_path_filename, NULL, LOAD_LIBRARY_AS_DATAFILE); + if(instance != NULL) + { + BOOL successful; + return_value = PickIconDlg_ClearIconsData(dialog); + if(return_value != eDoneSuccessfully) + { + successful = FreeLibrary(instance); + assert(successful); + return return_value; + } + successful = EnumResourceNamesW(instance, (LPCWSTR) RT_GROUP_ICON, + PickIconDlg_LoadImageNames, (LONG_PTR) dialog_data); + if(!successful) + { + DWORD last_error = GetLastError(); + successful = FreeLibrary(instance); + assert(successful); + if(last_error == ERROR_RESOURCE_TYPE_NOT_FOUND) + return eDoneSuccessfully; + dialog_data->error_code = last_error; + return PickIconDlg_ErrorCodeMeansSeriousError(dialog_data->error_code) ? + eNotDoneSeriousError : eNotDoneErrorNotSerious; + } + SendMessageW(control, WM_SETREDRAW, FALSE, 0); + update_successful = PickIconDlg_AddIconsToListViewUseLibrary(instance, dialog); + SendMessageW(control, WM_SETREDRAW, TRUE, 0); + successful = FreeLibrary(instance); + assert(successful); + if(!update_successful) + { + return PickIconDlg_ErrorCodeMeansSeriousError(dialog_data->error_code) ? + eNotDoneSeriousError : eNotDoneErrorNotSerious; + } + return eDoneSuccessfully; + } + else + { + DWORD last_error = GetLastError(); + if((last_error == ERROR_BAD_EXE_FORMAT) || (last_error == ERROR_RESOURCE_DATA_NOT_FOUND)) + { + return_value = PickIconDlg_ClearIconsData(dialog); + if(return_value != eDoneSuccessfully) + return return_value; + dialog_data->error_code = ERROR_SUCCESS; + return eDoneSuccessfully; + } + else + dialog_data->error_code = last_error; + return PickIconDlg_ErrorCodeMeansSeriousError(dialog_data->error_code) ? eNotDoneSeriousError : + eNotDoneErrorNotSerious; + } +} + + +static WCHAR *PickIconDlg_GetInputLine(const HWND dialog, const BOOL also_improve_input_line) +{ + HWND control; + WCHAR *buffer; + BOOL changed; + DWORD length; + control = GetDlgItem(dialog, IDC_PICKICONDLG_EDIT); + length = GetWindowTextLengthW(control); + buffer = malloc((length + 4 + 1) * sizeof(WCHAR)); + if(buffer == NULL) + return NULL; + GetWindowTextW(control, &buffer[4], length + 1); + changed = StrTrimW(&buffer[4], trim_chars); + length = lstrlenW(&buffer[4]); + if((length >= MAX_PATH) && also_improve_input_line) + { + WCHAR *short_path; + DWORD length2; + short_path = malloc((MAX_PATH + 4) * sizeof(WCHAR)); + if(short_path == NULL) + { + free(buffer); + return NULL; + } + memmove(buffer, extended_length_path_prefix, 4 * sizeof(WCHAR)); + length2 = GetShortPathNameW(buffer, short_path, MAX_PATH + 4); + if((length2 != 0) && (length2 - 4 < length)) + { + lstrcpyW(&buffer[4], &short_path[4]); + length = length2 - 4; + changed = TRUE; + } + free(short_path); + } + memmove(buffer, &buffer[4], length * sizeof(WCHAR) + sizeof(WCHAR)); + if(changed) + SetWindowTextW(control, buffer); + return buffer; +} + +/* + * IconIndex is like the parameter nIconIndex of function ExtractIconEx. + * ListViewItemIndex is like the return value of the ListView_FindItem macro + */ +static INT PickIconDlg_IconIndexToListViewItemIndex(const HWND dialog, const INT icon_index) +{ + INT counter = 0; + struct tag_IconDialogStruct *dialog_data = (struct tag_IconDialogStruct *) + GetWindowLongPtrW(dialog, DWLP_USER); + struct tagIconNamesStruct *current_record = dialog_data->first; + while(current_record != NULL) + { + if(icon_index >= 0) + { + if(counter > icon_index) + break; + if(counter == icon_index) + return counter; + } + if((current_record->icon_reference_to_index) && + (current_record->iconReferenceUnion.index == -icon_index) && + (current_record->image_list_index != IMAGE_LIST_INDEX_INVALID_VALUE)) + return counter; + current_record = current_record->next; + counter++; + } + return -1; +} + + +static INT PickIconDlg_ListViewItemIndexToIconIndex(const HWND dialog, const INT listview_item_index) +{ + LVITEMW item; + HWND control; + BOOL successful; + item.mask = LVIF_PARAM; + item.iItem = listview_item_index; + item.iSubItem = 0; + control = GetDlgItem(dialog, IDC_PICKICONDLG_ICONS); + successful = (BOOL) SendMessageW(control, LVM_GETITEMW, 0, (LPARAM) &item); + assert(successful); + return item.lParam; +} + + +static WCHAR *ReplicateString(const WCHAR *source) +{ + WCHAR *destination; + size_t str_len; + if(source == NULL) + return NULL; + str_len = wcslen(source); + destination = malloc((str_len + 1) * sizeof(WCHAR)); + if(destination != NULL) + wcscpy(destination, source); + return destination; +} + + +static enum enumActionResult PickIconDlg_UpdateData(const HWND dialog, + const BOOL evaluate_input_line, INT index_of_icon_to_focus) +{ + DWORD attributes; + HWND control, message_dialog_parent; + WCHAR *input_text = NULL, *extended_length_path_filename = NULL; + HINSTANCE instance; + enum enumActionResult return_value; + struct tag_IconDialogStruct *dialog_data = (struct tag_IconDialogStruct *) + GetWindowLongPtrW(dialog, DWLP_USER); + if(index_of_icon_to_focus == INT_MAX) + { + INT listview_index_to_focus; + control = GetDlgItem(dialog, IDC_PICKICONDLG_ICONS); + listview_index_to_focus = SendMessageW(control, LVM_GETNEXTITEM, -1, LVNI_FOCUSED); + if(listview_index_to_focus > -1) + index_of_icon_to_focus = PickIconDlg_ListViewItemIndexToIconIndex(dialog, + listview_index_to_focus); + else + index_of_icon_to_focus = 0; + } + message_dialog_parent = IsWindowVisible(dialog) ? dialog : + dialog_data->parent_of_pick_icon_dialog; + if(evaluate_input_line) + { + int length; + input_text = PickIconDlg_GetInputLine(dialog, TRUE); + if(input_text == NULL) + { + dialog_data->error_code = ERROR_OUTOFMEMORY; + return eNotDoneSeriousError; + } + control = GetDlgItem(dialog, IDC_PICKICONDLG_EDIT); + length = lstrlenW(input_text); + if((length >= MAX_PATH) || (length == 0)) + { + enum enumActionResult result; + free(input_text); + result = PickIconDlg_ClearIconsData(dialog); + dialog_data->path_filename_changed_without_data_update = FALSE; + if(result == eDoneSuccessfully) + { + dialog_data->error_code = ERROR_PATH_NOT_FOUND; + return eNotDoneErrorNotSerious; + } + else + return result; + } + extended_length_path_filename = PickIconDlg_CreateExpandedOrCompletedPathFileName( + input_text, TRUE); + if(extended_length_path_filename == NULL) + { + dialog_data->error_code = ERROR_OUTOFMEMORY; + free(input_text); + return eNotDoneSeriousError; + } + attributes = GetFileAttributesW(extended_length_path_filename); + if((attributes == INVALID_FILE_ATTRIBUTES) || ((attributes & FILE_ATTRIBUTE_DIRECTORY) > 0)) + { + free(extended_length_path_filename); + instance = (HINSTANCE) GetWindowLongPtrW(dialog, GWLP_HINSTANCE); + dialog_data->ignore_notifications = TRUE; + ShellMessageBoxW(instance, message_dialog_parent, + (WCHAR *) MAKEINTRESOURCE(IDS_PID_FILEDOESNOTEXIST), + (WCHAR *) MAKEINTRESOURCE(IDS_PID_CHANGEICONPROBLEM), MB_OK | MB_ICONSTOP, input_text); + dialog_data->ignore_notifications = FALSE; + free(input_text); + if(dialog_data->bad_input_error_message_showed) + { + enum enumActionResult state = PickIconDlg_ClearIconsData(dialog); + dialog_data->path_filename_changed_without_data_update = FALSE; + return state; + } + else + { + extended_length_path_filename = PickIconDlg_CreateExpandedOrCompletedPathFileName( + (const WCHAR *) shell32_dll_file_name, TRUE); + if(extended_length_path_filename == NULL) + { + dialog_data->error_code = ERROR_OUTOFMEMORY; + return eNotDoneSeriousError; + } + input_text = PickIconDlg_GetSystemDirectoryPathFilename((const WCHAR *) + shell32_dll_file_name, FALSE, TRUE); + if(input_text == NULL) + { + dialog_data->error_code = ERROR_OUTOFMEMORY; + free(extended_length_path_filename); + return eNotDoneSeriousError; + } + dialog_data->bad_input_error_message_showed = TRUE; + SetWindowTextW(control, input_text); + } + } + } + else + { + if(dialog_data->source_of_shown_icon_data == NULL) + return eDoneSuccessfully; + extended_length_path_filename = ReplicateString(dialog_data->source_of_shown_icon_data); + if(extended_length_path_filename == NULL) + { + dialog_data->error_code = ERROR_OUTOFMEMORY; + return eNotDoneSeriousError; + } + } + control = GetDlgItem(dialog, IDC_PICKICONDLG_ICONS); + if(PickIconDlg_IsIcoFile(extended_length_path_filename)) + return_value = PickIconDlg_UpdateImagesDataUseIcoFile(dialog, extended_length_path_filename); + else + return_value = PickIconDlg_UpdateImagesDataUseLibrary(dialog, extended_length_path_filename); + free(dialog_data->source_of_shown_icon_data); + dialog_data->source_of_shown_icon_data = extended_length_path_filename; + if(return_value == eDoneSuccessfully) + { + INT items_count = 0; + INT items_shown = SendMessageW(control, LVM_GETITEMCOUNT, 0, 0); + struct tagIconNamesStruct *current_record = dialog_data->first; + while(current_record != NULL) + { + current_record = current_record->next; + items_count++; + } + if((items_count == 0) || (items_shown < items_count)) + { + instance = (HINSTANCE) GetWindowLongPtrW(dialog, GWLP_HINSTANCE); + dialog_data->ignore_notifications = TRUE; + if(!items_count) + ShellMessageBoxW(instance, message_dialog_parent, (WCHAR *) + MAKEINTRESOURCE(IDS_PID_FILENOICONS), (WCHAR *) + MAKEINTRESOURCE(IDS_PID_CHANGEICONPROBLEM), MB_ICONWARNING | MB_OK, input_text); + else + ShellMessageBoxW(instance, message_dialog_parent, (WCHAR *) + MAKEINTRESOURCE(IDS_PID_ICONSPARTLYLOADED), (WCHAR *) + MAKEINTRESOURCE(IDS_PID_CHANGEICONPROBLEM), MB_OK | MB_ICONINFORMATION, + items_shown, items_count, input_text); + dialog_data->ignore_notifications = FALSE; + } + } + free(input_text); + dialog_data->path_filename_changed_without_data_update = FALSE; + if(return_value == eDoneSuccessfully) + { + INT index; + LVFINDINFOW find_info = { 0 }; + find_info.lParam = PickIconDlg_IconIndexToListViewItemIndex(dialog, + index_of_icon_to_focus); + find_info.flags = LVFI_PARAM; + index = SendMessageW(control, LVM_FINDITEMW, -1, (LPARAM) &find_info); + if(index > -1) + { + LVITEMW item; + item.state = item.stateMask = LVNI_SELECTED | LVNI_FOCUSED; + SendMessageW(control, LVM_SETITEMSTATE, (WPARAM) index, (LPARAM) (LPLVITEMW) &item); + SendMessageW(control, LVM_ENSUREVISIBLE, (WPARAM) index, (LPARAM) TRUE); + } + } + return return_value; +} + + +static VOID PickIconDlg_OnUpdateEditFilename(const HWND dialog) +{ + struct tag_IconDialogStruct *dialog_data = (VOID *) + GetWindowLongPtrW(dialog, DWLP_USER); + if(dialog_data != NULL) + dialog_data->path_filename_changed_without_data_update = TRUE; +} + + +static enum enumActionResult PickIconDlg_OnInit(const HWND dialog, + struct tag_IconDialogStruct *dialog_data) +{ + HWND control; + BOOL successful; + enum enumActionResult result; + SetWindowLongPtrW(dialog, DWLP_USER, (LONG_PTR) dialog_data); + dialog_data->first = dialog_data->last = NULL; + dialog_data->error_code = ERROR_SUCCESS; + assert(dialog_data->path_filename_max_chars > 0); + control = GetDlgItem(dialog, IDC_PICKICONDLG_EDIT); + SendMessageW(control, EM_LIMITTEXT, dialog_data->new_path_filename_max_length, 0); + StrTrimW(dialog_data->path_filename_allocated, trim_chars); + if(lstrlenW(dialog_data->path_filename_allocated) == 0) + { + WCHAR *new_text_field_value; + new_text_field_value = PickIconDlg_GetSystemDirectoryPathFilename((const WCHAR *) + shell32_dll_file_name, FALSE, TRUE); + if(new_text_field_value == NULL) + { + dialog_data->error_code = ERROR_OUTOFMEMORY; + return eNotDoneSeriousError; + } + successful = SetWindowTextW(control, new_text_field_value); + free(new_text_field_value); + } + else + successful = SetWindowTextW(control, dialog_data->path_filename_allocated); + assert(successful); + dialog_data->path_filename_changed_without_data_update = TRUE; + SendDlgItemMessageW(dialog, IDC_PICKICONDLG_ICONS, LVM_SETEXTENDEDLISTVIEWSTYLE, 0, + LVS_EX_BORDERSELECT +#ifdef LVS_EX_HIDELABELS_IMPLEMENTED + | LVS_EX_HIDELABELS +#endif + ); + result = PickIconDlg_UpdateData(dialog, TRUE, dialog_data->icon_index); + return result; +} + + +static enum enumActionResult PickIconDlg_UpdatePathFilenameAllocated(const HWND dialog) +{ + WCHAR *input_line; + enum enumActionResult result = eDoneSuccessfully; + struct tag_IconDialogStruct *dialog_data = (struct tag_IconDialogStruct *) + GetWindowLongPtrW(dialog, DWLP_USER); + input_line = PickIconDlg_GetInputLine(dialog, FALSE); + if(input_line == NULL) + { + dialog_data->error_code = ERROR_OUTOFMEMORY; + result = eNotDoneSeriousError; + } + if(result == eDoneSuccessfully) + { + swprintf(dialog_data->path_filename_allocated, dialog_data->path_filename_max_chars, + mask_s, input_line); + free(input_line); + } + return result; +} + + +static enum enumActionResult PickIconDlg_OnConfirmation(const HWND dialog) +{ + HWND control; + INT icon_count; + INT index; + struct tag_IconDialogStruct *dialog_data = (struct tag_IconDialogStruct *) + GetWindowLongPtrW(dialog, DWLP_USER); + if(dialog_data->path_filename_changed_without_data_update == TRUE) + { + enum enumActionResult answer = PickIconDlg_UpdateData(dialog, TRUE, 0); + return answer; + } + icon_count = SendDlgItemMessageW(dialog, IDC_PICKICONDLG_ICONS, LVM_GETITEMCOUNT, 0, 0); + if(icon_count == 0) + { + enum enumActionResult result = PickIconDlg_UpdatePathFilenameAllocated(dialog); + if(result == eDoneSuccessfully) + { + dialog_data->icon_index = 0; + return eDoneSuccessfullyWithAcceptableConfirmation; + } + else + return result; + } + else + { + struct tagIconNamesStruct *current_record; + BOOL successful; + INT counter = 0; + LVITEMW item = { 0 }; + control = GetDlgItem(dialog, IDC_PICKICONDLG_ICONS); + index = SendMessageW(control, LVM_GETNEXTITEM, (WPARAM) -1, (LPARAM) LVNI_FOCUSED); + if(index == -1) + return eNotDoneNoError; + item.mask = LVIF_IMAGE; + item.iItem = index; + successful = SendMessageW(control, LVM_GETITEMW, 0, (LPARAM) &item); + assert(successful); + current_record = dialog_data->first; + while(current_record != NULL) + { + if(current_record->image_list_index == item.iImage) + { + enum enumActionResult result; + dialog_data->icon_index = counter; + result = PickIconDlg_ClearIconsData(dialog); + if(result == eDoneSuccessfully) + result = PickIconDlg_UpdatePathFilenameAllocated(dialog); + if(result == eDoneSuccessfully) + return eDoneSuccessfullyWithAcceptableConfirmation; + else + return result; + } + current_record = current_record->next; + counter++; + } + } + return eNotDoneNoError; +} + + +static enum enumActionResult PickIconDlg_OnClickButton(const HWND dialog) +{ + HWND hwnd; + OPENFILENAMEW ofn; + WCHAR *selection_text = NULL; + HINSTANCE instance; + DWORD text_length, length; + WCHAR *input_line_path_filename, *input_line_short_path_filename, *input_line_text; + enum enumActionResult return_value; + struct tag_IconDialogStruct *dialog_data; + + dialog_data = (struct tag_IconDialogStruct *) GetWindowLongPtrW(dialog, DWLP_USER); + ZeroMemory(&ofn, sizeof(ofn)); + ofn.lStructSize = sizeof(ofn); + ofn.hwndOwner = dialog; + ofn.nMaxFile = MAX_PATH; + hwnd = GetDlgItem(dialog, IDC_PICKICONDLG_EDIT); + input_line_text = PickIconDlg_GetInputLine(dialog, FALSE); + ofn.lpstrFile = malloc(ofn.nMaxFile * sizeof(WCHAR)); + if((input_line_text == NULL) || (ofn.lpstrFile == NULL)) + { + if(input_line_text != NULL) + free(input_line_text); + if(ofn.lpstrFile != NULL) + free(ofn.lpstrFile); + dialog_data->error_code = ERROR_OUTOFMEMORY; + return eNotDoneSeriousError; + } + input_line_path_filename = PickIconDlg_CreateExpandedOrCompletedPathFileName( + input_line_text, TRUE); + free(input_line_text); + if(input_line_path_filename == NULL) + { + dialog_data->error_code = ERROR_OUTOFMEMORY; + return eNotDoneSeriousError; + } + if(lstrlenW(&input_line_path_filename[4]) >= MAX_PATH) + { + DWORD length_long; + input_line_short_path_filename = malloc((MAX_PATH + 4) * sizeof(WCHAR)); + if(input_line_short_path_filename == NULL) + { + free(input_line_path_filename); + dialog_data->error_code = ERROR_OUTOFMEMORY; + return eNotDoneSeriousError; + } + length_long = lstrlenW(input_line_path_filename); + length = GetShortPathNameW(input_line_path_filename, + input_line_short_path_filename, MAX_PATH + 4); + if(length <= 4) + ofn.lpstrFile[0] = 0; + else if((length - 4 < ofn.nMaxFile) && (length < length_long)) + lstrcpyW(ofn.lpstrFile, &input_line_short_path_filename[4]); + free(input_line_short_path_filename); + } + else + lstrcpyW(ofn.lpstrFile, &input_line_path_filename[4]); + free(input_line_path_filename); + instance = (HINSTANCE) GetWindowLongPtrW(dialog, GWLP_HINSTANCE); + text_length = LoadStringW(instance, IDS_PID_ICONFILEEXTENSIONS, (WCHAR *) + &selection_text, 0); + assert(text_length > 0); + ofn.lpstrFilter = selection_text; + ofn.lpstrTitle = NULL; + ofn.Flags = OFN_EXPLORER | OFN_FILEMUSTEXIST | OFN_HIDEREADONLY; + if(GetOpenFileNameW(&ofn)) + { + SetWindowTextW(hwnd, ofn.lpstrFile); + return_value = PickIconDlg_UpdateData(dialog, TRUE, 0); + } + else + return_value = eDoneSuccessfully; + free(ofn.lpstrFile); + return return_value; +} + + +static enum enumActionResult PickIconDlg_OnNotify(const HWND dialog, const LPNMHDR lparam) +{ + struct tag_IconDialogStruct *dialog_data = (struct tag_IconDialogStruct *) + GetWindowLongPtrW(dialog, DWLP_USER); + if(dialog_data) + if(dialog_data->ignore_notifications) + return eNotDoneNoError; + switch(lparam->code) + { + case NM_DBLCLK: + return PickIconDlg_OnConfirmation(dialog); + case NM_SETFOCUS: + if(dialog_data->path_filename_changed_without_data_update) + return PickIconDlg_UpdateData(dialog, TRUE, 0); + break; + } + return eNotDoneNoError; +} + + +static VOID PickIconDlg_ShowErrorMessageAndClearErrorCode(const HWND dialog, + struct tag_IconDialogStruct *dialog_data, const WORD ids_body_text_mask) +{ + static const WCHAR mask_u[] = { '%', 'u', 0 }; + const DWORD flags = FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_ALLOCATE_BUFFER | + FORMAT_MESSAGE_IGNORE_INSERTS; + LPWSTR system_message = NULL; + WCHAR number[6]; + HINSTANCE instance; + DWORD chars; + instance = (HINSTANCE) GetWindowLongPtrW(dialog, GWLP_HINSTANCE); + chars = FormatMessageW(flags, NULL, dialog_data->error_code, + MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), + (LPWSTR) &system_message, 0, NULL); + if(chars == 0) + { + swprintf(number, ARRAYSIZE(number), mask_u, dialog_data->error_code); + system_message = number; + } + dialog_data->ignore_notifications = TRUE; + ShellMessageBoxW(instance, dialog, (WCHAR *) MAKEINTRESOURCE(ids_body_text_mask), (WCHAR *) + MAKEINTRESOURCE(IDS_PID_CHANGEICONPROBLEM), MB_OK | MB_ICONSTOP, system_message, + dialog_data->error_code); + if(chars > 0) + LocalFree(system_message); + dialog_data->ignore_notifications = FALSE; + dialog_data->error_code = ERROR_SUCCESS; +} + + +static VOID PickIconDlg_ProcessSuccessState(const HWND dialog, const enum enumActionResult what_happened) +{ + struct tag_IconDialogStruct *dialog_data; + switch(what_happened) + { + case eDoneSuccessfullyWithAcceptableConfirmation: + PickIconDlg_ClearIconsData(dialog); + EndDialog(dialog, IDOK); + break; + case eNotDoneErrorNotSerious: + dialog_data = (struct tag_IconDialogStruct *) GetWindowLongPtrW(dialog, DWLP_USER); + PickIconDlg_ShowErrorMessageAndClearErrorCode(IsWindowVisible(dialog) ? dialog : + dialog_data->parent_of_pick_icon_dialog, dialog_data, IDS_PID_PROCESSINGFAILURE); + break; + case eNotDoneSeriousError: + PickIconDlg_ClearIconsData(dialog); + EndDialog(dialog, IDCANCEL); + break; + default: + ; + } +} + + +static INT_PTR CALLBACK PickIconDlg_Proc(HWND dialog, UINT message, + WPARAM wparam, LPARAM lparam) +{ + struct tag_IconDialogStruct *dialog_data; + enum enumActionResult success_state; + switch(message) + { + case WM_INITDIALOG: + dialog_data = (struct tag_IconDialogStruct *) lparam; + success_state = PickIconDlg_OnInit(dialog, dialog_data); + PickIconDlg_ProcessSuccessState(dialog, success_state); + return TRUE; + case WM_COMMAND: + switch(LOWORD(wparam)) + { + case IDOK: + success_state = PickIconDlg_OnConfirmation(dialog); + PickIconDlg_ProcessSuccessState(dialog, success_state); + break; + case IDCANCEL: + PickIconDlg_ClearIconsData(dialog); + EndDialog(dialog, IDCANCEL); + break; + case IDC_PICKICONDLG_EDIT: + if(HIWORD(wparam) == EN_UPDATE) + PickIconDlg_OnUpdateEditFilename(dialog); + break; + case IDC_PICKICONDLG_CHANGE: + if(HIWORD(wparam) == BN_CLICKED) + { + success_state = PickIconDlg_OnClickButton(dialog); + PickIconDlg_ProcessSuccessState(dialog, success_state); + } + } + break; + case WM_NOTIFY: + success_state = PickIconDlg_OnNotify(dialog, (LPNMHDR) lparam); + PickIconDlg_ProcessSuccessState(dialog, success_state); + break; + case WM_DPICHANGED: + success_state = PickIconDlg_UpdateData(dialog, FALSE, INT_MAX); + PickIconDlg_ProcessSuccessState(dialog, success_state); + break; + default: + return FALSE; + } + return TRUE; +} + /************************************************************************* * PickIconDlg [SHELL32.62] * */ -INT WINAPI PickIconDlg(HWND hwndOwner, WCHAR *path, UINT path_len, INT *index) +INT WINAPI PickIconDlg(HWND hwnd_owner, WCHAR *path, UINT path_len, INT *index) { - FIXME("(%p,%s,%u,%p):stub.\n", hwndOwner, debugstr_w(path), path_len, index); - return 0xffffffff; + size_t needed_bytes, needed_bytes2; + HINSTANCE instance; + BOOL icon_selected = FALSE; + INITCOMMONCONTROLSEX comm_ctls_ex = { sizeof(comm_ctls_ex), ICC_LISTVIEW_CLASSES }; + struct tag_IconDialogStruct dialog_data = { 0 }; + if((path == NULL) || (index == NULL)) + return 0; + InitCommonControlsEx(&comm_ctls_ex); + instance = shell32_hInstance; + if(hwnd_owner != NULL) + { + if(!IsWindow(hwnd_owner)) + { + SetLastError(ERROR_INVALID_WINDOW_HANDLE); + /* Here, an implementation that does not correspond to the documentation is + * being reprogrammed. */ + return 1; + } + } + dialog_data.parent_of_pick_icon_dialog = hwnd_owner; + if(path_len < 2) + dialog_data.new_path_filename_max_length = 1; + else + dialog_data.new_path_filename_max_length = path_len - 1; + needed_bytes = sizeof(WCHAR) * (dialog_data.new_path_filename_max_length + 1); + needed_bytes2 = (lstrlenW(path) + 1) * sizeof(WCHAR); + if(needed_bytes < needed_bytes2) + needed_bytes = needed_bytes2; + dialog_data.path_filename_allocated = malloc(needed_bytes); + if(dialog_data.path_filename_allocated == NULL) + dialog_data.error_code = ERROR_OUTOFMEMORY; + else + dialog_data.error_code = ERROR_SUCCESS; + if(dialog_data.error_code == ERROR_SUCCESS) + { + lstrcpyW(dialog_data.path_filename_allocated, path); + dialog_data.icon_index = *index; + dialog_data.path_filename_max_chars = needed_bytes / sizeof(WCHAR); + icon_selected = DialogBoxParamW(instance, (WCHAR *) MAKEINTRESOURCE(IDD_PICKICONDLG), hwnd_owner, + PickIconDlg_Proc, (LPARAM) &dialog_data) == IDOK; + } + if(dialog_data.error_code == ERROR_SUCCESS) + { + if(icon_selected) + { + *index = dialog_data.icon_index; + swprintf(path, path_len, mask_s, dialog_data.path_filename_allocated); + } + } + else + { + WCHAR *system_message = NULL; + const DWORD flags = FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_ALLOCATE_BUFFER; + FormatMessageW(flags, NULL, dialog_data.error_code, + MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), (WCHAR *) &system_message, 0, NULL); + ShellMessageBoxW(instance, hwnd_owner, (WCHAR *) MAKEINTRESOURCE(IDS_PID_DIALOGCOULDNOTBEDISPLAYED), + (WCHAR *) MAKEINTRESOURCE(IDS_PID_CHANGEICONPROBLEM), MB_OK | MB_ICONSTOP, system_message); + LocalFree(system_message); + } + if(dialog_data.path_filename_allocated != NULL) + free(dialog_data.path_filename_allocated); + SetLastError(dialog_data.error_code); + return icon_selected ? 1 : 0; } + HRESULT WINAPI SHOpenWithDialog(HWND parent, const OPENASINFO *info) { FIXME("stub\n"); diff --git a/dlls/shell32/shell32.rc b/dlls/shell32/shell32.rc index fe80339568b..a910c0dadc3 100644 --- a/dlls/shell32/shell32.rc +++ b/dlls/shell32/shell32.rc @@ -22,6 +22,21 @@ #pragma makedep po +LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT +IDD_PICKICONDLG DIALOG 0, 0, 230, 192 +STYLE DS_MODALFRAME | DS_CENTER | WS_POPUP | WS_CAPTION | WS_SYSMENU +CAPTION "Change Icon" +FONT 8, "MS Shell Dlg" +BEGIN + LTEXT "Search for icons in &file:", IDC_PICKICONDLG_LABELPATH, 10, 10, 210, 8 + EDITTEXT IDC_PICKICONDLG_EDIT, 10, 20, 160, 14, WS_VISIBLE | WS_CHILD | WS_TABSTOP | ES_AUTOHSCROLL | ES_LEFT + PUSHBUTTON "&Change...", IDC_PICKICONDLG_CHANGE, 171, 20, 49, 14, WS_VISIBLE | WS_CHILD | BS_PUSHBUTTON + LTEXT "List of the icons in the file, please &select:", IDC_PICKICONDLG_LABELICONS, 10, 39, 210, 9 + CONTROL "", IDC_PICKICONDLG_ICONS, "SysListView32", LVS_ICON | LVS_SINGLESEL | LVS_SHOWSELALWAYS | LVS_AUTOARRANGE | LVS_ALIGNLEFT | WS_CHILD | WS_VISIBLE | WS_BORDER | WS_TABSTOP, 10, 49, 210, 115 + DEFPUSHBUTTON "OK", IDOK, 116, 170, 50, 14, WS_VISIBLE | WS_CHILD | WS_TABSTOP | BS_DEFPUSHBUTTON + PUSHBUTTON "Cancel", IDCANCEL, 170, 170, 50, 14, WS_VISIBLE | WS_CHILD | WS_TABSTOP +END + LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT MENU_001 MENU @@ -127,6 +142,17 @@ BEGIN END END +STRINGTABLE +{ + IDS_PID_ICONFILEEXTENSIONS "Files containing icons (*.ico;*.dll;*.exe)\0*.ico;*.dll;*.exe\0All files (*.*)\0*.*\0\0" + IDS_PID_DIALOGCOULDNOTBEDISPLAYED "The 'Change Icon' dialog could not be displayed because:\r\n%1" + IDS_PID_FILEDOESNOTEXIST "The file '%1' does not exist." + IDS_PID_PROCESSINGFAILURE "The 'Change Icon' dialog module failed to process some data successfully because the following error occurred:\r\nError %2!u!: %1" + IDS_PID_FILENOICONS "The file\r\n'%1'\r\ndoes not contain any icons." + IDS_PID_ICONSPARTLYLOADED "Only %1!i! of %2!i! icons could be loaded successfully from the file\r\n'%3'." + IDS_PID_CHANGEICONPROBLEM "Change Icon Problem" +} + STRINGTABLE { /* columns in the shellview */ diff --git a/dlls/shell32/shresdef.h b/dlls/shell32/shresdef.h index deabe568022..ea4fbfca716 100644 --- a/dlls/shell32/shresdef.h +++ b/dlls/shell32/shresdef.h @@ -26,6 +26,15 @@ #include <shlobj.h> #include <dlgs.h> +/* PickIconDlg message-box texts */ +#define IDS_PID_ICONFILEEXTENSIONS 100 +#define IDS_PID_DIALOGCOULDNOTBEDISPLAYED 101 +#define IDS_PID_FILEDOESNOTEXIST 102 +#define IDS_PID_PROCESSINGFAILURE 103 +#define IDS_PID_FILENOICONS 104 +#define IDS_PID_ICONSPARTLYLOADED 105 +#define IDS_PID_CHANGEICONPROBLEM 106 + /* columntitles for the shellview */ @@ -156,6 +165,8 @@ /* Note: this string is referenced from the registry*/ #define IDS_RECYCLEBIN_FOLDER_NAME 8964 +#define IDD_PICKICONDLG 7 + /* Properties dialog */ #define IDD_FILE_PROPERTIES 8 #define IDD_FOLDER_PROPERTIES 9 @@ -389,6 +400,13 @@ FIXME: Need to add them, but for now just let them use the same: searching.avi #define IDR_AVI_FILENUKE 163 #define IDR_AVI_FILEDELETE 164 +/* PickIconDlg box */ +#define IDC_PICKICONDLG_LABELPATH 1001 +#define IDC_PICKICONDLG_EDIT 1002 +#define IDC_PICKICONDLG_CHANGE 1003 +#define IDC_PICKICONDLG_LABELICONS 1004 +#define IDC_PICKICONDLG_ICONS 1005 + /* about box */ #define IDC_ABOUT_LICENSE 97 #define IDC_ABOUT_WINE_TEXT 98 -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/9477
participants (2)
-
Matthias Zorn -
Matthias Zorn (＠Matthias-Zorn.0178)