[PATCH v5 0/1] MR2552: wineboot: Add env variable to hide wait window
Add a new environment variable WINEHIDEWAIT to disable configuration wait windows. Useful for wine wrappers that want to keep the UX seamless. -- v5: Add env variable to hide wait window https://gitlab.winehq.org/wine/wine/-/merge_requests/2552
From: Isaac Marovitz <isaacryu(a)icloud.com> Fix oopsie Check if null 3rd times the charm Diff --- programs/wineboot/wineboot.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/programs/wineboot/wineboot.c b/programs/wineboot/wineboot.c index c05ce580298..14fd9f0c5dc 100644 --- a/programs/wineboot/wineboot.c +++ b/programs/wineboot/wineboot.c @@ -1341,7 +1341,10 @@ static HWND show_wait_window(void) { HWND hwnd = CreateDialogParamW( GetModuleHandleW(0), MAKEINTRESOURCEW(IDD_WAITDLG), 0, wait_dlgproc, (LPARAM)prettyprint_configdir() ); - ShowWindow( hwnd, SW_SHOWNORMAL ); + WCHAR *hide = _wgetenv( L"WINEHIDEWAIT" ); + if (hide == NULL) { + ShowWindow( hwnd, SW_SHOWNORMAL ); + } return hwnd; } -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/2552
I love the idea of this pull request, but `WINEHIDEWAIT` seems meh. <https://www.winehq.org/docs/wine> <- There is doc with all other env variables. `WINEBOOT_HIDE_DIALOG` seems more something I'll prefer, I'll share this MR with wine-tkg community to see which names they prefer. Since how the variable name is entirely cosmetic, there is no right or wrong answer as long as it match the spirit of other env variables. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2552#note_28578
On Sat Apr 1 16:35:42 2023 +0000, Loïc Rebmeister wrote:
I love the idea of this pull request, but `WINEHIDEWAIT` seems meh. <https://www.winehq.org/docs/wine> <- There is doc with all other env variables. `WINEBOOT_HIDE_DIALOG` seems more something I'll prefer, I'll share this MR with wine-tkg community to see which names they prefer. Since how the variable name is entirely cosmetic, there is no right or wrong answer as long as it match the spirit of other env variables. `WINEBOOT_HIDE_DIALOG` lgtm
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2552#note_28587
participants (3)
-
Isaac Marovitz -
Isaac Marovitz (@IsaacMarovitz) -
Loïc Rebmeister