[PATCH 0/3] MR7792: ntdll: Fix some memory leaks (Valgrind).

[Sven Baars (＠sbaars)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7792

[PATCH 1/3] ntdll/tests: Fix a leak on error path (Coverity).

[Sven Baars]

From: Sven Baars <sbaars(a)codeweavers.com>

---
 dlls/ntdll/tests/file.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c
index b663efbef8f..006e92f14f4 100644
--- a/dlls/ntdll/tests/file.c
+++ b/dlls/ntdll/tests/file.c
@@ -726,7 +726,10 @@ static void read_file_test(void)
     CloseHandle( handle );
 
     if (!(handle = create_temp_file(FILE_FLAG_OVERLAPPED | FILE_FLAG_NO_BUFFERING)))
+    {
+        CloseHandle(event);
         return;
+    }
 
     apc_count = 0;
     offset.QuadPart = 0;
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/7792

[PATCH 2/3] ntdll/tests: Fix a string leak (Valgrind).

[Sven Baars]

From: Sven Baars <sbaars(a)codeweavers.com>

---
 dlls/ntdll/tests/file.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c
index 006e92f14f4..dee5b04d77e 100644
--- a/dlls/ntdll/tests/file.c
+++ b/dlls/ntdll/tests/file.c
@@ -4905,6 +4905,7 @@ static void test_NtCreateFile(void)
                             0, FILE_SHARE_READ|FILE_SHARE_WRITE, FILE_CREATE,
                             FILE_DIRECTORY_FILE, NULL, 0);
     ok( !status, "failed %s %lx\n", debugstr_w(nameW.Buffer), status );
+    pRtlFreeUnicodeString( &nameW );
     RemoveDirectoryW( path );
 }
 
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/7792

[PATCH 3/3] ntdll: Empty the atom table before destroying it (Valgrind).

[Sven Baars]

From: Sven Baars <sbaars(a)codeweavers.com>

---
 dlls/ntdll/atom.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/ntdll/atom.c b/dlls/ntdll/atom.c
index 650210cc2cc..45f5771e252 100644
--- a/dlls/ntdll/atom.c
+++ b/dlls/ntdll/atom.c
@@ -280,6 +280,7 @@ NTSTATUS WINAPI RtlCreateAtomTable( ULONG size, RTL_ATOM_TABLE *ret_table )
 NTSTATUS WINAPI RtlDestroyAtomTable( RTL_ATOM_TABLE table )
 {
     if (!table || table->Signature != TABLE_SIGNATURE) return STATUS_INVALID_PARAMETER;
+    RtlEmptyAtomTable( table, TRUE );
     RtlDestroyHandleTable( &table->HandleTable );
     RtlDeleteCriticalSection( &table->CriticalSection );
     table->Signature = 0;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/7792