[PATCH 0/3] MR8601: d3dx: Fix Clang -Wuninitialized-const-pointer warnings.

[Jacek Caban (＠jacek)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8601

[PATCH 1/3] d3dx9/tests: Fix identity_matrix initialization.

[Jacek Caban]

From: Jacek Caban <jacek(a)codeweavers.com>

Fixes Clang -Wuninitialized-const-pointer warning.
---
 dlls/d3dx9_36/tests/mesh.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dlls/d3dx9_36/tests/mesh.c b/dlls/d3dx9_36/tests/mesh.c
index ef472f00865..23597dc2d56 100644
--- a/dlls/d3dx9_36/tests/mesh.c
+++ b/dlls/d3dx9_36/tests/mesh.c
@@ -5221,6 +5221,8 @@ static void test_create_skin_info(void)
         D3DXMATRIX *transform;
         D3DXMATRIX identity_matrix;
 
+        D3DXMatrixIdentity(&identity_matrix);
+
         /* test initial values */
         hr = skininfo->lpVtbl->GetDeclaration(skininfo, declaration_out);
         ok(hr == D3D_OK, "Expected D3D_OK, got %#lx\n", hr);
@@ -5260,7 +5262,6 @@ static void test_create_skin_info(void)
             hr = skininfo->lpVtbl->SetBoneOffsetMatrix(skininfo, 0, NULL);
             ok(hr == D3DERR_INVALIDCALL, "Expected D3DERR_INVALIDCALL, got %#lx\n", hr);
 
-            D3DXMatrixIdentity(&identity_matrix);
             hr = skininfo->lpVtbl->SetBoneOffsetMatrix(skininfo, 0, &identity_matrix);
             ok(hr == D3D_OK, "Expected D3D_OK, got %#lx\n", hr);
 
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/8601

[PATCH 2/3] d3dx10/tests: Initialize data in test_D3DX10CreateAsyncMemoryLoader.

[Jacek Caban]

From: Jacek Caban <jacek(a)codeweavers.com>

Fixes Clang -Wuninitialized-const-pointer warning.
---
 dlls/d3dx10_43/tests/d3dx10.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/dlls/d3dx10_43/tests/d3dx10.c b/dlls/d3dx10_43/tests/d3dx10.c
index f7f2e2e32f8..08038c75de8 100644
--- a/dlls/d3dx10_43/tests/d3dx10.c
+++ b/dlls/d3dx10_43/tests/d3dx10.c
@@ -2110,7 +2110,7 @@ static void test_D3DX10CreateAsyncMemoryLoader(void)
 {
     ID3DX10DataLoader *loader;
     SIZE_T size;
-    DWORD data;
+    DWORD data = 0;
     HRESULT hr;
     void *ptr;
 
@@ -2136,7 +2136,6 @@ static void test_D3DX10CreateAsyncMemoryLoader(void)
     hr = ID3DX10DataLoader_Destroy(loader);
     ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr);
 
-    data = 0;
     hr = D3DX10CreateAsyncMemoryLoader(&data, sizeof(data), &loader);
     ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr);
 
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/8601

[PATCH 3/3] d3dx11/tests: Initialize data in test_D3DX11CreateAsyncMemoryLoader.

[Jacek Caban]

From: Jacek Caban <jacek(a)codeweavers.com>

Fixes Clang -Wuninitialized-const-pointer warning.
---
 dlls/d3dx11_43/tests/d3dx11.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/d3dx11_43/tests/d3dx11.c b/dlls/d3dx11_43/tests/d3dx11.c
index 16c0f0bc03e..a1de78f4e1e 100644
--- a/dlls/d3dx11_43/tests/d3dx11.c
+++ b/dlls/d3dx11_43/tests/d3dx11.c
@@ -310,7 +310,7 @@ static void test_D3DX11CreateAsyncMemoryLoader(void)
 {
     ID3DX11DataLoader *loader;
     SIZE_T size;
-    DWORD data;
+    DWORD data = 0;
     HRESULT hr;
     void *ptr;
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/8601

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx11_43/tests/d3dx11.c:
> hr = ID3DX11DataLoader_Destroy(loader);
>      ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr);
>
> data = 0;

We can get rid of this as well, like the previous patch.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8601#note_110636

[PATCH 0/3] MR8601: d3dx: Fix Clang -Wuninitialized-const-pointer warnings. - approved

[Matteo Bruni (＠Mystral)]

This merge request was approved by Matteo Bruni.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8601