[PATCH 0/1] MR4506: msi: Fix an use-after-free (Coverity).

[Zhiyi Zhang (＠zhiyi)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4506

[PATCH 1/1] msi: Fix an use-after-free (Coverity).

[Zhiyi Zhang]

From: Zhiyi Zhang <zzhang(a)codeweavers.com>

---
 dlls/msi/files.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/dlls/msi/files.c b/dlls/msi/files.c
index 96c6c5eaa4b..1dbdc72f4f8 100644
--- a/dlls/msi/files.c
+++ b/dlls/msi/files.c
@@ -988,7 +988,7 @@ static BOOL move_files_wildcard( MSIPACKAGE *package, const WCHAR *source, WCHAR
     HANDLE hfile;
     LPWSTR path;
     BOOL res;
-    struct file_list files, *file;
+    struct file_list files, *file, *file2;
     DWORD size;
 
     hfile = msi_find_first_file( package, source, &wfd );
@@ -1032,10 +1032,8 @@ static BOOL move_files_wildcard( MSIPACKAGE *package, const WCHAR *source, WCHAR
     file->dest[size - 1] = '\0';
     lstrcpyW(wcsrchr(file->dest, '\\') + 1, file->destname);
 
-    while (!list_empty(&files.entry))
+    LIST_FOR_EACH_ENTRY_SAFE(file, file2, &files.entry, struct file_list, entry)
     {
-        file = LIST_ENTRY(list_head(&files.entry), struct file_list, entry);
-
         move_file( package, file->source, file->dest, options );
 
         list_remove(&file->entry);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4506

[Nikolay Sivov (＠nsivov)]

I don't see it, where is the use-after-free here?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4506#note_53847

[Zhiyi Zhang (＠zhiyi)]

On Mon Nov 27 01:37:08 2023 +0000, Nikolay Sivov wrote:
> I don't see it, where is the use-after-free here?
> On second look, this seems like a false positive. The Coverity link is https://scan5.scan.coverity.com/reports.htm#v57929/p10088/fileInstanceId=253.... Closing.

![image](/uploads/9e06ea93705399d4383ebd78814f40fc/image.png)

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4506#note_53860

[PATCH 0/1] MR4506: msi: Fix an use-after-free (Coverity). - closed

[Zhiyi Zhang (＠zhiyi)]

This merge request was closed by Zhiyi Zhang.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4506