[PATCH v2 0/2] MR1893: increase number of midi ports to 64
While this doesn't fully fix https://bugs.winehq.org/show_bug.cgi?id=50703 as we can read in the code comments ideally the number of devices is "unbound" it does resolve the immediate issue that I've been facing. Since the total number of ports displayed is both hardware + software it's incredibly easy to go beyond just 16. The increase to 64 helps a lot, but is still not perfect. We could also set it to 128 or 256, but it's still arbitrary. I think this would already be enough for the vast majority of cases, but I guess they also thought this with 16 ;) -- v2: update comment https://gitlab.winehq.org/wine/wine/-/merge_requests/1893
From: dreamer <dreamer(a)puikheid.nl> --- include/mmddk.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/mmddk.h b/include/mmddk.h index d4217f2ebef..02115754f1a 100644 --- a/include/mmddk.h +++ b/include/mmddk.h @@ -30,13 +30,13 @@ extern "C" { #endif -#define MAX_MIDIINDRV (16) +#define MAX_MIDIINDRV (64) /* For now I'm making 16 the maximum number of midi devices one can * have. This should be more than enough for everybody. But as a purist, * I intend to make it unbounded in the future, as soon as I figure * a good way to do so. */ -#define MAX_MIDIOUTDRV (16) +#define MAX_MIDIOUTDRV (64) /* ================================== * Multimedia DDK compatible part -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/1893
From: dreamer <dreamer(a)puikheid.nl> --- include/mmddk.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/mmddk.h b/include/mmddk.h index 02115754f1a..e237683a164 100644 --- a/include/mmddk.h +++ b/include/mmddk.h @@ -31,7 +31,7 @@ extern "C" { #endif #define MAX_MIDIINDRV (64) -/* For now I'm making 16 the maximum number of midi devices one can +/* For now I'm making 64 the maximum number of midi devices one can * have. This should be more than enough for everybody. But as a purist, * I intend to make it unbounded in the future, as soon as I figure * a good way to do so. -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/1893
Please add your real name to your gitlab profile and change your git config to commit under your full name as well. Have a look at: https://wiki.winehq.org/Submitting_Patches#Check_your_Git_setup -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1893#note_20208
If this isn't a Windows definition (which by all appearances it isn't), we should remove it and make the code able to handle an arbitrary number. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1893#note_20212
On Sat Dec 31 12:29:07 2022 +0000, Zebediah Figura wrote:
If this isn't a Windows definition (which by all appearances it isn't), we should remove it and make the code able to handle an arbitrary number. Agreed, however I don't know the wine code-base at all so wouldn't know where to start.
Any suggestions on how to properly do this are welcome of course :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1893#note_20217
participants (5)
-
Alexander (＠dreamer) -
Alexander Chalikiopoulos (＠dreamer)
-
dreamer
-
Gijs Vermeulen (＠gverm)
-
Zebediah Figura (＠zfigura)