[PATCH v2 0/1] MR9512: widl: Fix MethodList value for apicontract typedefs.

[Vibhav Pant (＠vibhavp)]

apicontract typedefs don't have any associated methods, so the MethodList value should be 0.

--
  v2: widl: Fix MethodList value for apicontract and enum typedefs.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9512

[Vibhav Pant (＠vibhavp)]

On Wed Nov 19 11:38:23 2025 +0000, Hans Leidekker wrote:
> Please also fix the add_typedef_row() call in add_enum_type_step2().
> Pushed, thanks.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9512#note_122946

[PATCH v2 1/1] widl: Fix MethodList value for apicontract and enum typedefs.

[Vibhav Pant]

From: Vibhav Pant <vibhavp(a)gmail.com>

---
 tools/widl/metadata.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/widl/metadata.c b/tools/widl/metadata.c
index 16fb015f50e..7c830579fec 100644
--- a/tools/widl/metadata.c
+++ b/tools/widl/metadata.c
@@ -2005,7 +2005,7 @@ static void add_enum_type_step2( type_t *type )
                            add_string("value__"), add_blob(sig_value, sizeof(sig_value)) );
 
     type->md.def = add_typedef_row( TYPE_ATTR_PUBLIC | TYPE_ATTR_SEALED | TYPE_ATTR_UNKNOWN, type->md.name,
-                                    type->md.namespace, type->md.extends, field, 1 );
+                                    type->md.namespace, type->md.extends, field, 0 );
 
     sig_size = make_field_value_sig( typedef_or_ref(TABLE_TYPEREF, type->md.ref), sig_field );
 
@@ -2740,7 +2740,7 @@ static void add_apicontract_type_step2( type_t *type )
 {
     UINT flags = TYPE_ATTR_PUBLIC | TYPE_ATTR_SEQUENTIALLAYOUT | TYPE_ATTR_SEALED | TYPE_ATTR_UNKNOWN;
 
-    type->md.def = add_typedef_row( flags, type->md.name, type->md.namespace, type->md.extends, 0, 1 );
+    type->md.def = add_typedef_row( flags, type->md.name, type->md.namespace, type->md.extends, 0, 0 );
 
     add_contractversion_attr_step2( type );
     add_apicontract_attr_step2( type );
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/9512

[PATCH v2 0/1] MR9512: widl: Fix MethodList value for apicontract typedefs. - approved

[Hans Leidekker (＠hans)]

This merge request was approved by Hans Leidekker.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9512