Re: [PATCH v5 0/1] MR826: wined3d: Add support for Renoir GPUs

[Etaash Mathamsetty (＠etaash.mathamsetty)]

On Tue Sep 13 15:10:00 2022 +0000, Henri Verbeet wrote:
> > As far as I can tell it was changed (perhaps inadvertently) by Mesa
> > commit 0cb42c57c569443b0af8296dfff4da1e6ab241ef. Previously "AMD" string
> > would be present in the renderer string for cases where there was no
> > marketing name (i.e. Etaash's gpu would have a GL_RENDERER value
> > beginning with "AMD RENOIR").
> > Looks plausible enough; ideally we'd get that fixed.
> > As far as I can tell, radeonsi has only ever reported a GL_VENDOR of
> > "X.org" or (more recently) "AMD", so we've been relying on "AMD" being
> > present in the renderer string.
> > It's slightly worse, actually. Cards with a "marketing" name will have a
> > renderer string like "Radeon RX Vega (VEGA10, ...)", so for these we'd
> > depend on the "Radeon"/"FirePro" strings. If the vendor string now
> > includes "AMD" we'd certainly want to use that; in that regard the
> > original commit is fine.
> > It may also be a good idea to try matching the card vendor based on
> > the PCI vendor first; I imagine that will remain a bit more stable
> > against changes like this.
> > Yes, I think that would be helpful.
> > I modified the PR to use the PCI id yesterday, so there's no need to "guess" which card this is anymore, and it works as expected.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/826#note_8343