[PATCH 0/1] MR1056: win32u: Asynchronously send the WM_DISPLAYCHANGE to the desktop window.

[Rémi Bernon]

I'm not sure this would solve the problem from https://gitlab.winehq.org/wine/wine/-/merge_requests/944?commit_id=bc09f0812... as I'm not yet able to reproduce it, but I suspect it might help. In any case I don't think there's any good reason for this call to be synchronous with send_message.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1056

[PATCH 1/1] win32u: Asynchronously send the WM_DISPLAYCHANGE to the desktop window.

[Rémi Bernon]

From: Rémi Bernon <rbernon(a)codeweavers.com>

---
 dlls/win32u/message.c        | 2 +-
 dlls/win32u/sysparams.c      | 4 ++--
 dlls/win32u/win32u_private.h | 1 +
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/dlls/win32u/message.c b/dlls/win32u/message.c
index 51967d2598a..caffd837c8b 100644
--- a/dlls/win32u/message.c
+++ b/dlls/win32u/message.c
@@ -3047,7 +3047,7 @@ LRESULT send_message( HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam )
 }
 
 /* see SendNotifyMessageW */
-static BOOL send_notify_message( HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam, BOOL ansi )
+BOOL send_notify_message( HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam, BOOL ansi )
 {
     struct send_message_info info;
 
diff --git a/dlls/win32u/sysparams.c b/dlls/win32u/sysparams.c
index 1c81dda9dd3..6b5a6f65aef 100644
--- a/dlls/win32u/sysparams.c
+++ b/dlls/win32u/sysparams.c
@@ -2487,8 +2487,8 @@ static LONG apply_display_settings( const WCHAR *devname, const DEVMODEW *devmod
         user_driver->pGetCurrentDisplaySettings( adapter->dev.device_name, ¤t_mode );
         adapter_release( adapter );
 
-        send_message( NtUserGetDesktopWindow(), WM_DISPLAYCHANGE, current_mode.dmBitsPerPel,
-                      MAKELPARAM( current_mode.dmPelsWidth, current_mode.dmPelsHeight ) );
+        send_notify_message( NtUserGetDesktopWindow(), WM_DISPLAYCHANGE, current_mode.dmBitsPerPel,
+                             MAKELPARAM( current_mode.dmPelsWidth, current_mode.dmPelsHeight ), FALSE );
         send_message_timeout( HWND_BROADCAST, WM_DISPLAYCHANGE, current_mode.dmBitsPerPel,
                               MAKELPARAM( current_mode.dmPelsWidth, current_mode.dmPelsHeight ),
                               SMTO_ABORTIFHUNG, 2000, FALSE );
diff --git a/dlls/win32u/win32u_private.h b/dlls/win32u/win32u_private.h
index 298cafcf7bf..4be068b968d 100644
--- a/dlls/win32u/win32u_private.h
+++ b/dlls/win32u/win32u_private.h
@@ -308,6 +308,7 @@ extern LRESULT send_internal_message_timeout( DWORD dest_pid, DWORD dest_tid, UI
                                               LPARAM lparam, UINT flags, UINT timeout,
                                               PDWORD_PTR res_ptr ) DECLSPEC_HIDDEN;
 extern LRESULT send_message( HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam ) DECLSPEC_HIDDEN;
+extern BOOL send_notify_message( HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam, BOOL ansi ) DECLSPEC_HIDDEN;
 extern LRESULT send_message_timeout( HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam,
                                      UINT flags, UINT timeout, BOOL ansi );
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1056

[PATCH 1/1] win32u: Asynchronously send the WM_DISPLAYCHANGE to the desktop window.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=124971

Your paranoid android.


=== debian11 (build log) ===

Use of uninitialized value $Flaky in addition (+) at /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24858.
Use of uninitialized value $Flaky in addition (+) at /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24858.
Use of uninitialized value $Flaky in addition (+) at /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24858.