Re: [PATCH v4 0/1] MR203: vkd3d-shader/hlsl: Fold constant integral abs().

[Francisco Casas (＠fcasas)]

On Thu May 18 20:19:08 2023 +0000, Zebediah Figura wrote:
> > I might have misread, but doesn't the return value apply to the full
> > vector and not its components? I thought returning false made it so the
> > whole abs op was left alone if any component was INT_MIN, like an
> > all-or-nothing deal.
> > That is the case, yes. That said, I believe we want to make that change anyway.
> > Indeed, I didn't have the big picture in mind. returning false keeps the original instruction.

However, I also think that we should go for the change in case we ever call hlsl_fold_constant_exprs() from somewhere else.

-- 
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/203#note_33140