[PATCH 0/1] MR1691: kernel32/tests: Use the strcasecmp function instead of reimplementing it.

[Alex Henrie (＠alexhenrie)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1691

[PATCH 1/1] kernel32/tests: Use the strcasecmp function instead of reimplementing it.

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

---
 dlls/kernel32/tests/process.c | 21 +--------------------
 1 file changed, 1 insertion(+), 20 deletions(-)

diff --git a/dlls/kernel32/tests/process.c b/dlls/kernel32/tests/process.c
index 0d877f715aa..a15f8dd1fa8 100644
--- a/dlls/kernel32/tests/process.c
+++ b/dlls/kernel32/tests/process.c
@@ -547,31 +547,12 @@ static WCHAR* getChildStringW(const char* sect, const char* key)
     return ret;
 }
 
-/* FIXME: this may be moved to the wtmain.c file, because it may be needed by
- * others... (windows uses stricmp while Un*x uses strcasecmp...)
- */
-static int wtstrcasecmp(const char* p1, const char* p2)
-{
-    char c1, c2;
-
-    c1 = c2 = '@';
-    while (c1 == c2 && c1)
-    {
-        c1 = *p1++; c2 = *p2++;
-        if (c1 != c2)
-        {
-            c1 = toupper(c1); c2 = toupper(c2);
-        }
-    }
-    return c1 - c2;
-}
-
 static int strCmp(const char* s1, const char* s2, BOOL sensitive)
 {
     if (!s1 && !s2) return 0;
     if (!s2) return -1;
     if (!s1) return 1;
-    return (sensitive) ? strcmp(s1, s2) : wtstrcasecmp(s1, s2);
+    return (sensitive) ? strcmp(s1, s2) : strcasecmp(s1, s2);
 }
 
 static void ok_child_string( int line, const char *sect, const char *key,
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1691

[PATCH 1/1] kernel32/tests: Use the strcasecmp function instead of reimplementing it.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=127226

Your paranoid android.


=== w1064v1809 (64 bit report) ===

kernel32:
process.c:4962: Test failed: got 0xc0000004