Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/ws2_32/tests/sock.c:
> +    ok(listener != INVALID_SOCKET, "Could not create Unix socket: %lu\n",
> +        GetLastError());
> +
> +    ret = bind(listener, (SOCKADDR *)&addr, sizeof(SOCKADDR_UN));
> +    ok(!ret, "Could not bind Unix socket: %lu\n", GetLastError());
> +
> +    ret = listen(listener, 1);
> +    ok(!ret, "Could not listen on Unix socket: %lu\n", GetLastError());
> +
> +    client = socket(AF_UNIX, SOCK_STREAM, 0);
> +    ok(client != INVALID_SOCKET, "Failed to create second Unix socket: %lu\n",
> +        GetLastError());
> +
> +    clientThread = CreateThread(NULL, 0, test_afunix_client_connect_thread,
> +                                &(struct afunix_thread_param){ client, addr }, 0, NULL);
> +    ok(clientThread != NULL, "CreateThread failed unexpectedly: %ld\n", GetLastError());
> Do we need to bother with the client thread here? (Could we potentially make the client socket nonblocking instead?)

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_35924