Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets
16 Jun
2023
16 Jun
'23
5:31 p.m.
Zebediah Figura (@zfigura) commented about dlls/ws2_32/socket.c:
if (!(sync_event = get_sync_event())) return -1;
- params = malloc( sizeof(int) + len ); - ret_addr = malloc( len ); + if (addr->sa_family == AF_UNIX && *addr->sa_data)
Accessing sa_data in this way is convenient, but looks wrong. I'd rather just see the cast to sockaddr_un written out anyway. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2786#note_35919
918
Age (days ago)
918
Last active (days ago)
0 comments
1 participants
participants (1)
-
Zebediah Figura (@zfigura)