[PATCH 0/1] MR6943: msvcp140: Add a version resource.

[Louis Lenders (＠xe)]

This fixes an error that was reported at the forum: https://forum.winehq.org/viewtopic.php?t=39757

The application (PrismLive) prints an error in the console (error: Failed to get msvcp140.dll version info size) and refuses to start.

The application can be found at https://prismlive.com/en_us/#

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6943

[PATCH 1/1] msvcp140: Add a version resource.

[Louis Lenders]

From: Louis Lenders <xerox.xerox2000x(a)gmail.com>

---
 dlls/msvcp140/Makefile.in |  3 ++-
 dlls/msvcp140/version.rc  | 26 ++++++++++++++++++++++++++
 2 files changed, 28 insertions(+), 1 deletion(-)
 create mode 100644 dlls/msvcp140/version.rc

diff --git a/dlls/msvcp140/Makefile.in b/dlls/msvcp140/Makefile.in
index 5a8c8950f04..fd68c0302a3 100644
--- a/dlls/msvcp140/Makefile.in
+++ b/dlls/msvcp140/Makefile.in
@@ -13,4 +13,5 @@ SOURCES = \
 	memory.c \
 	misc.c \
 	msvcp_main.c \
-	string.c
+	string.c \
+	version.rc
diff --git a/dlls/msvcp140/version.rc b/dlls/msvcp140/version.rc
new file mode 100644
index 00000000000..7e31ee4a5db
--- /dev/null
+++ b/dlls/msvcp140/version.rc
@@ -0,0 +1,26 @@
+/*
+ * Copyright 2024 Louis Lenders
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
+ */
+
+#define WINE_FILEDESCRIPTION_STR "Wine runtime library"
+#define WINE_FILENAME_STR "msvcp140.dll"
+#define WINE_FILEVERSION 14,42,34433,0
+#define WINE_FILEVERSION_STR "14.42.34433.0"
+#define WINE_PRODUCTVERSION 14,42,34433,0
+#define WINE_PRODUCTVERSION_STR "14.42.34433.0"
+
+#include "wine/wine_common_ver.rc"
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/6943

[Piotr Caban (＠piotr)]

The patch looks good for me. It will break tools like `winetricks` because native C Runtime Redistributable installer checks file versions before updating files. Such tools will need to be updated.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6943#note_89546

[PATCH 0/1] MR6943: msvcp140: Add a version resource. - approved

[Piotr Caban (＠piotr)]

This merge request was approved by Piotr Caban.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6943