[PATCH 0/1] MR2760: activeds: Free memory on error paths (coverity)

[Alistair Leslie-Hughes (＠alesliehughes)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2760

[PATCH 1/1] activeds: Free memory on error paths (coverity)

[Alistair Leslie-Hughes]

From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>

---
 dlls/activeds/pathname.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/dlls/activeds/pathname.c b/dlls/activeds/pathname.c
index 943afd5603d..05db9bc8071 100644
--- a/dlls/activeds/pathname.c
+++ b/dlls/activeds/pathname.c
@@ -136,7 +136,10 @@ static HRESULT parse_path(BSTR path, BSTR *provider, BSTR *server, BSTR *dn)
     if (!*p) return S_OK;
 
     if (*p++ != '/' || *p++ != '/' || !*p)
+    {
+        SysFreeString(*provider);
         return E_ADS_BAD_PATHNAME;
+    }
 
     p_server = p;
     server_len = 0;
@@ -145,7 +148,11 @@ static HRESULT parse_path(BSTR path, BSTR *provider, BSTR *server, BSTR *dn)
         p++;
         server_len++;
     }
-    if (server_len == 0) return E_ADS_BAD_PATHNAME;
+    if (server_len == 0)
+    {
+        SysFreeString(*provider);
+        return E_ADS_BAD_PATHNAME;
+    }
 
     *server = SysAllocStringLen(p_server, server_len);
     if (!*server)
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2760