Re: [PATCH v18 0/4] MR4661: gdiplus: Implement Gdiplus effects
22 Jan
2024
22 Jan
'24
6:34 p.m.
Esme Povirk (@madewokherd) commented about dlls/gdiplus/image.c:
+ { + if (paramsize != size) + return InvalidParameter; + } + + switch (effect->type) + { + case BlurEffect: + alloc_copy(params, effect->p.blurparams, size); + break; + case SharpenEffect: + alloc_copy(params, effect->p.sharpenparams, size); + break; + case TintEffect: + alloc_copy(params, effect->p.tintparams, size); + break; I think all the cases except RedEyeCorrectionEffect can be combined into one case. I don't think the `default:` case should be reachable.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_58438
775
Age (days ago)
775
Last active (days ago)
0 comments
1 participants
participants (1)
-
Esme Povirk (@madewokherd)