[PATCH 0/1] MR2235: dlls/dxgi: Don't warn on DXGI_ALPHA_MODE_UNSPECIFIED with wined3d
Wine's dxgi implementation doesn't handle the different DXGI_ALPHA_MODE values, save for DXGI_ALPHA_MODE_IGNORE on both vkd3d (d3d12) and wined3d (d3d11), but prints a fixme for DXGI_ALPHA_MODE_UNSPECIFIED for wined3d but not vkd3d. To match the behaviour between the two, and because the "Unspecified" mode seems like it should always be acceptable to ignore, don't print a fixme in the wined3d path either. This eliminates the following warning: 010c:fixme:dxgi:wined3d_swapchain_desc_from_dxgi Ignoring alpha mode 0. See the msdn docs for DXGI_ALPHA_MODE here: https://learn.microsoft.com/en-us/windows/win32/api/dxgi1_2/ne-dxgi1_2-dxgi_... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2235
From: David Gow <david(a)ingeniumdigital.com> Wine's dxgi implementation doesn't handle the different DXGI_ALPHA_MODE values, save for DXGI_ALPHA_MODE_IGNORE on both vkd3d (d3d12) and wined3d (d3d11), but prints a fixme for DXGI_ALPHA_MODE_UNSPECIFIED for wined3d but not vkd3d. To match the behaviour between the two, and because the "Unspecified" mode seems like it should always be acceptable to ignore, don't print a fixme in the wined3d path either. This eliminates the following warning: 010c:fixme:dxgi:wined3d_swapchain_desc_from_dxgi Ignoring alpha mode 0. See the msdn docs for DXGI_ALPHA_MODE here: https://learn.microsoft.com/en-us/windows/win32/api/dxgi1_2/ne-dxgi1_2-dxgi_... --- dlls/dxgi/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/dxgi/utils.c b/dlls/dxgi/utils.c index e99951e0a04..08e3a0d39db 100644 --- a/dlls/dxgi/utils.c +++ b/dlls/dxgi/utils.c @@ -572,7 +572,7 @@ HRESULT wined3d_swapchain_desc_from_dxgi(struct wined3d_swapchain_desc *wined3d_ if (dxgi_desc->Scaling != DXGI_SCALING_STRETCH) FIXME("Ignoring scaling %#x.\n", dxgi_desc->Scaling); - if (dxgi_desc->AlphaMode != DXGI_ALPHA_MODE_IGNORE) + if (dxgi_desc->AlphaMode != DXGI_ALPHA_MODE_UNSPECIFIED && dxgi_desc->AlphaMode != DXGI_ALPHA_MODE_IGNORE) FIXME("Ignoring alpha mode %#x.\n", dxgi_desc->AlphaMode); if (dxgi_fullscreen_desc && dxgi_fullscreen_desc->ScanlineOrdering) FIXME("Unhandled scanline ordering %#x.\n", dxgi_fullscreen_desc->ScanlineOrdering); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/2235
This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2235
This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2235
participants (4)
-
David Gow -
David Gow (＠sulix)
-
Jan Sikorski (＠jsikorski)
-
Zebediah Figura (＠zfigura)