[PATCH v2 0/1] MR1965: d3d12/tests: Fix the expected dxgi adapter refcount check.
-- v2: d3d12/tests: Fix the expected dxgi adapter refcount check. https://gitlab.winehq.org/wine/wine/-/merge_requests/1965
From: Francois Gouget <fgouget(a)codeweavers.com> The refcount is 0 on Windows 10 1909+ so consider the 1709 and 1809 results to be buggy. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54299 --- dlls/d3d12/tests/d3d12.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/d3d12/tests/d3d12.c b/dlls/d3d12/tests/d3d12.c index 0d3deafda45..12f26e150bd 100644 --- a/dlls/d3d12/tests/d3d12.c +++ b/dlls/d3d12/tests/d3d12.c @@ -885,7 +885,8 @@ static void test_create_device(void) hr = D3D12CreateDevice((IUnknown *)adapter, D3D_FEATURE_LEVEL_11_0, &IID_ID3D12Device, (void **)&device); ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr); refcount = IDXGIAdapter_Release(adapter); - ok(refcount >= 1, "Got unexpected refcount %lu.\n", refcount); + todo_wine ok(refcount == 0 || broken(refcount >= 1 /* win10 1709 & 1809 */), + "Got unexpected refcount %lu.\n", refcount); adapter = NULL; luid = ID3D12Device_GetAdapterLuid(device); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/1965
v2: Added a todo_wine -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1965#note_21121
I don't think the GitLab CI's qasf:asfreader failures are related to this merge request: while there is no trace of these failures in the WineTest results, MR!1668 had the exact same set of failures (see https://gitlab.winehq.org/epo/wine/-/jobs/7268). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1965#note_21122
I wrote a more elaborate reply in the linked bug report a couple of days ago, but essentially I think this line (as well as the "refcount" assignment in the line above it) can just be dropped. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1965#note_21156
participants (3)
-
Francois Gouget -
Francois Gouget (＠fgouget)
-
Henri Verbeet (＠hverbeet)