[PATCH v2 0/1] MR3549: Draft: gdiplus: add more test to GdipCreateCustomLineCap
-- v2: gdiplus: add more test to GdipCreateCustomLineCap https://gitlab.winehq.org/wine/wine/-/merge_requests/3549
From: Bartosz Kosiorek <gang65(a)poczta.onet.pl> --- dlls/gdiplus/tests/customlinecap.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/dlls/gdiplus/tests/customlinecap.c b/dlls/gdiplus/tests/customlinecap.c index a8bb5cf371b..54900bbba81 100644 --- a/dlls/gdiplus/tests/customlinecap.c +++ b/dlls/gdiplus/tests/customlinecap.c @@ -75,11 +75,27 @@ static void test_constructor_destructor(void) expect(InvalidParameter, stat); /* valid args */ - stat = GdipCreateCustomLineCap(NULL, path2, LineCapFlat, 0.0, &custom); + custom = NULL; + stat = GdipCreateCustomLineCap(NULL, path2, LineCapTriangle, 0.0, &custom); + expect(Ok, stat); + ok(custom != NULL, "Custom line cap was not created\n"); + stat = GdipDeleteCustomLineCap(custom); + expect(Ok, stat); + + custom = NULL; + stat = GdipCreateCustomLineCap(path, NULL, LineCapFlat, 0.0, &custom); expect(Ok, stat); + ok(custom != NULL, "Custom line cap was not created\n"); stat = GdipDeleteCustomLineCap(custom); expect(Ok, stat); - /* it's strange but native returns NotImplemented on stroke == NULL */ + + custom = NULL; + stat = GdipCreateCustomLineCap(path, NULL, LineCapFlat, 2.0, &custom); + todo_wine expect(NotImplemented, stat); + todo_wine ok(custom == NULL, "Expected a failure on creation\n"); + if(stat == Ok) GdipDeleteCustomLineCap(custom); + + /* if baseInset is too large compared to Cap size, then it returns NotImplemented */ custom = NULL; stat = GdipCreateCustomLineCap(path, NULL, LineCapFlat, 10.0, &custom); todo_wine expect(NotImplemented, stat); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/3549
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=135955 Your paranoid android. === w7u_2qxl (32 bit report) === gdiplus: customlinecap.c:87: Test failed: Expected 00000000, got 00000006 customlinecap.c:88: Test failed: Custom line cap was not created customlinecap.c:90: Test failed: Expected 00000000, got 00000002 === w7u_adm (32 bit report) === gdiplus: customlinecap.c:87: Test failed: Expected 00000000, got 00000006 customlinecap.c:88: Test failed: Custom line cap was not created customlinecap.c:90: Test failed: Expected 00000000, got 00000002 === w7u_el (32 bit report) === gdiplus: customlinecap.c:87: Test failed: Expected 00000000, got 00000006 customlinecap.c:88: Test failed: Custom line cap was not created customlinecap.c:90: Test failed: Expected 00000000, got 00000002 === w8 (32 bit report) === gdiplus: customlinecap.c:87: Test failed: Expected 00000000, got 00000006 customlinecap.c:88: Test failed: Custom line cap was not created customlinecap.c:90: Test failed: Expected 00000000, got 00000002 === w8adm (32 bit report) === gdiplus: customlinecap.c:87: Test failed: Expected 00000000, got 00000006 customlinecap.c:88: Test failed: Custom line cap was not created customlinecap.c:90: Test failed: Expected 00000000, got 00000002 === w864 (32 bit report) === gdiplus: customlinecap.c:87: Test failed: Expected 00000000, got 00000006 customlinecap.c:88: Test failed: Custom line cap was not created customlinecap.c:90: Test failed: Expected 00000000, got 00000002 === w1064v1507 (32 bit report) === gdiplus: customlinecap.c:87: Test failed: Expected 00000000, got 00000006 customlinecap.c:88: Test failed: Custom line cap was not created customlinecap.c:90: Test failed: Expected 00000000, got 00000002 === w1064v1809 (32 bit report) === gdiplus: customlinecap.c:87: Test failed: Expected 00000000, got 00000006 customlinecap.c:88: Test failed: Custom line cap was not created customlinecap.c:90: Test failed: Expected 00000000, got 00000002 === w1064_tsign (32 bit report) === gdiplus: customlinecap.c:87: Test failed: Expected 00000000, got 00000006 customlinecap.c:88: Test failed: Custom line cap was not created customlinecap.c:90: Test failed: Expected 00000000, got 00000002 === w10pro64 (32 bit report) === gdiplus: customlinecap.c:87: Test failed: Expected 00000000, got 00000006 customlinecap.c:88: Test failed: Custom line cap was not created customlinecap.c:90: Test failed: Expected 00000000, got 00000002 === w11pro64 (32 bit report) === gdiplus: customlinecap.c:87: Test failed: Expected 00000000, got 00000006 customlinecap.c:88: Test failed: Custom line cap was not created customlinecap.c:90: Test failed: Expected 00000000, got 00000002 === w7pro64 (64 bit report) === gdiplus: customlinecap.c:87: Test failed: Expected 00000000, got 00000006 customlinecap.c:88: Test failed: Custom line cap was not created customlinecap.c:90: Test failed: Expected 00000000, got 00000002 === w864 (64 bit report) === gdiplus: customlinecap.c:87: Test failed: Expected 00000000, got 00000006 customlinecap.c:88: Test failed: Custom line cap was not created customlinecap.c:90: Test failed: Expected 00000000, got 00000002 === w1064v1507 (64 bit report) === gdiplus: customlinecap.c:87: Test failed: Expected 00000000, got 00000006 customlinecap.c:88: Test failed: Custom line cap was not created customlinecap.c:90: Test failed: Expected 00000000, got 00000002 === w1064v1809 (64 bit report) === gdiplus: customlinecap.c:87: Test failed: Expected 00000000, got 00000006 customlinecap.c:88: Test failed: Custom line cap was not created customlinecap.c:90: Test failed: Expected 00000000, got 00000002 === w1064_2qxl (64 bit report) === gdiplus: customlinecap.c:87: Test failed: Expected 00000000, got 00000006 customlinecap.c:88: Test failed: Custom line cap was not created customlinecap.c:90: Test failed: Expected 00000000, got 00000002 === w1064_adm (64 bit report) === gdiplus: customlinecap.c:87: Test failed: Expected 00000000, got 00000006 customlinecap.c:88: Test failed: Custom line cap was not created customlinecap.c:90: Test failed: Expected 00000000, got 00000002 === w1064_tsign (64 bit report) === gdiplus: customlinecap.c:87: Test failed: Expected 00000000, got 00000006 customlinecap.c:88: Test failed: Custom line cap was not created customlinecap.c:90: Test failed: Expected 00000000, got 00000002 === w10pro64 (64 bit report) === gdiplus: customlinecap.c:87: Test failed: Expected 00000000, got 00000006 customlinecap.c:88: Test failed: Custom line cap was not created customlinecap.c:90: Test failed: Expected 00000000, got 00000002 === w10pro64_en_AE_u8 (64 bit report) === gdiplus: customlinecap.c:87: Test failed: Expected 00000000, got 00000006 customlinecap.c:88: Test failed: Custom line cap was not created customlinecap.c:90: Test failed: Expected 00000000, got 00000002 === w10pro64_ar (64 bit report) === gdiplus: customlinecap.c:87: Test failed: Expected 00000000, got 00000006 customlinecap.c:88: Test failed: Custom line cap was not created customlinecap.c:90: Test failed: Expected 00000000, got 00000002 === w10pro64_ja (64 bit report) === gdiplus: customlinecap.c:87: Test failed: Expected 00000000, got 00000006 customlinecap.c:88: Test failed: Custom line cap was not created customlinecap.c:90: Test failed: Expected 00000000, got 00000002 === w10pro64_zh_CN (64 bit report) === gdiplus: customlinecap.c:87: Test failed: Expected 00000000, got 00000006 customlinecap.c:88: Test failed: Custom line cap was not created customlinecap.c:90: Test failed: Expected 00000000, got 00000002 === w11pro64_amd (64 bit report) === gdiplus: customlinecap.c:87: Test failed: Expected 00000000, got 00000006 customlinecap.c:88: Test failed: Custom line cap was not created customlinecap.c:90: Test failed: Expected 00000000, got 00000002
participants (3)
-
Bartosz Kosiorek -
Bartosz Kosiorek (＠gang65)
-
Marvin