[PATCH 0/1] MR3273: wineps: Fix SetTextJustification playback with 0 count parameter.

[Piotr Caban (＠piotr)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55078

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3273

[PATCH 1/1] wineps: Fix SetTextJustification playback with 0 count parameter.

[Piotr Caban]

From: Piotr Caban <piotr(a)codeweavers.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55078
---
 dlls/wineps.drv/printproc.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/dlls/wineps.drv/printproc.c b/dlls/wineps.drv/printproc.c
index 9cd1efd5d5d..72e5540b5be 100644
--- a/dlls/wineps.drv/printproc.c
+++ b/dlls/wineps.drv/printproc.c
@@ -2792,8 +2792,16 @@ static int WINAPI hmf_proc(HDC hdc, HANDLETABLE *htable,
     {
         const EMRSETTEXTJUSTIFICATION *p = (const EMRSETTEXTJUSTIFICATION *)rec;
 
-        data->break_extra = p->break_extra / p->break_count;
-        data->break_rem = p->break_extra - data->break_extra * p->break_count;
+        if (p->break_count)
+        {
+            data->break_extra = p->break_extra / p->break_count;
+            data->break_rem = p->break_extra - data->break_extra * p->break_count;
+        }
+        else
+        {
+            data->break_extra = 0;
+            data->break_rem = 0;
+        }
         return PlayEnhMetaFileRecord(data->ctx->hdc, htable, rec, handle_count);
     }
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/3273

[PATCH 1/1] wineps: Fix SetTextJustification playback with 0 count parameter.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=134619

Your paranoid android.


=== debian11 (32 bit report) ===

Report validation errors:
xinput1_3:xinput crashed (c0000005)

[PATCH 0/1] MR3273: wineps: Fix SetTextJustification playback with 0 count parameter. - approved

[Huw Davies (＠huw)]

This merge request was approved by Huw Davies.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3273