[PATCH v9 0/7] MR7111: Draft: support building Wine with LTO
work is still in progress. todo: - ensure that all affected sources (i.e. C sources with any kind of assembly) are listed in either way for all architectures - test Wine built with LTO relevant bug reports: - https://bugs.winehq.org/show_bug.cgi?id=41712 - https://bugs.winehq.org/show_bug.cgi?id=51051 -- v9: LTO quirks configure: enable building Wine with LTO makedep: support skipping/disabling LTO makedep: support LTO builds winegcc: support LTO builds winebuild: support LTO builds tools: helper functions for LTO builds https://gitlab.winehq.org/wine/wine/-/merge_requests/7111
From: Konstantin Demin <rockdrilla(a)gmail.com> Signed-off-by: Konstantin Demin <rockdrilla(a)gmail.com> --- tools/tools.h | 98 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 98 insertions(+) diff --git a/tools/tools.h b/tools/tools.h index f017bab0e93..d4776ee1ddb 100644 --- a/tools/tools.h +++ b/tools/tools.h @@ -958,4 +958,102 @@ static inline struct strarray parse_options( int argc, char **argv, const char * #undef OPT_ERR } +static inline void append_lto_flags( struct strarray *args, int with_lto, int prefer_env ) +{ + if (with_lto < 0) return; + + if (prefer_env > 0) + { + const char *flags; + + if (with_lto > 0) + { + static int init_lto = 0; + static const char* flags_lto; + + if (!init_lto) + { + flags_lto = getenv( "WINE_LTO_FLAGS" ); + if (flags_lto) flags_lto = xstrdup( flags_lto ); + init_lto = 1; + } + flags = flags_lto; + } + else + { + static int init_lto_skip = 0; + static const char* flags_lto_skip; + + if (!init_lto_skip) + { + flags_lto_skip = getenv( "WINE_LTO_SKIP_FLAGS" ); + if (flags_lto_skip) flags_lto_skip = xstrdup( flags_lto_skip ); + init_lto_skip = 1; + } + flags = flags_lto_skip; + } + + if (flags) { + strarray_addall( args, strarray_fromstring( flags, " " ) ); + return; + } + } + + strarray_add( args, (with_lto > 0) ? "-flto" : "-fno-lto" ); +} + +static inline int var_to_bool( const char *var ) +{ + if (!var) return 0; + if (!( var[0] )) return 0; + + switch (var[0]) + { + /* "1" */ + case '1': + if (!var[1]) return 1; + break; + + /* "[Tt]", "[Tt][Rr][Uu][Ee]" */ + case 'T': /* -fallthrough */ + case 't': + if (!var[1]) return 1; + + if (strlen( var ) != 4) break; + if ((var[1] != 'R') && (var[1] != 'r')) break; + if ((var[2] != 'U') && (var[2] != 'u')) break; + if ((var[3] != 'E') && (var[3] != 'e')) break; + return 1; + + break; + + /* "[Yy]", "[Yy][Ee][Ss]" */ + case 'Y': /* -fallthrough */ + case 'y': + if (!var[1]) return 1; + + if (strlen( var ) != 3) break; + if ((var[1] != 'E') && (var[1] != 'e')) break; + if ((var[2] != 'S') && (var[2] != 's')) break; + return 1; + + break; + } + + return 0; +} + +static inline int adjust_verbose_lto( int with_lto, int verbose ) +{ + const char* lto_debug; + + if (with_lto < 1) return verbose; + if (verbose > 0) return verbose; + + lto_debug = getenv( "WINE_LTO_DEBUG" ); + if (!lto_debug) return verbose; + + return var_to_bool( lto_debug ); +} + #endif /* __WINE_TOOLS_H */ -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/7111
From: Konstantin Demin <rockdrilla(a)gmail.com> Signed-off-by: Konstantin Demin <rockdrilla(a)gmail.com> --- tools/winebuild/build.h | 1 + tools/winebuild/import.c | 47 +++++++++++++++++++++++++++++++++++++--- tools/winebuild/main.c | 6 ++++- tools/winebuild/utils.c | 27 +++++++++++++++++++++-- 4 files changed, 75 insertions(+), 6 deletions(-) diff --git a/tools/winebuild/build.h b/tools/winebuild/build.h index e5ede93425b..f6a57db1a2e 100644 --- a/tools/winebuild/build.h +++ b/tools/winebuild/build.h @@ -363,6 +363,7 @@ extern void put_pword( unsigned int val ); extern int current_line; extern int UsePIC; +extern int UseLTO; extern int nb_errors; extern int display_warnings; extern int kill_at; diff --git a/tools/winebuild/import.c b/tools/winebuild/import.c index eba74bb9660..224c4007a66 100644 --- a/tools/winebuild/import.c +++ b/tools/winebuild/import.c @@ -1241,11 +1241,31 @@ static const char *get_target_machine(void) /* build a library from the current asm files and any additional object files in argv */ void output_static_lib( const char *output_name, struct strarray files, int create ) { - struct strarray args; + struct strarray args = empty_strarray; if (!create || target.platform != PLATFORM_WINDOWS) { - args = find_tool( "ar", NULL ); + static int init_env_ar = 0; + static const char * env_ar; + + if (!init_env_ar) + { + if ((env_ar = getenv( "WINE_AR" ))) + { + /* duplicate string if non-empty; otherwise set to NULL */ + env_ar = (env_ar[0]) ? xstrdup( env_ar ) : NULL; + } + init_env_ar = 1; + } + if (env_ar) + { + const char * _cmd[2] = { env_ar, NULL }; + args = find_tool( "ar", _cmd ); + } + if (!args.count) + { + args = find_tool( "ar", NULL ); + } strarray_add( &args, create ? "rc" : "r" ); strarray_add( &args, output_name ); } @@ -1263,7 +1283,28 @@ void output_static_lib( const char *output_name, struct strarray files, int crea if (target.platform != PLATFORM_WINDOWS) { - struct strarray ranlib = find_tool( "ranlib", NULL ); + static int init_env_ranlib = 0; + static const char * env_ranlib; + struct strarray ranlib = empty_strarray; + + if (!init_env_ranlib) + { + if ((env_ranlib = getenv( "WINE_RANLIB" ))) + { + /* duplicate string if non-empty; otherwise set to NULL */ + env_ranlib = (env_ranlib[0]) ? xstrdup( env_ranlib ) : NULL; + } + init_env_ranlib = 1; + } + if (env_ranlib) + { + const char * _cmd[2] = { env_ranlib, NULL }; + ranlib = find_tool( "ranlib", _cmd ); + } + if (!ranlib.count) + { + ranlib = find_tool( "ranlib", NULL ); + } strarray_add( &ranlib, output_name ); spawn( ranlib ); } diff --git a/tools/winebuild/main.c b/tools/winebuild/main.c index 63d65e7bcd0..e48c5afb194 100644 --- a/tools/winebuild/main.c +++ b/tools/winebuild/main.c @@ -34,6 +34,7 @@ #include "build.h" int UsePIC = 0; +int UseLTO = -1; int nb_errors = 0; int display_warnings = 0; int native_arch = -1; @@ -185,7 +186,7 @@ static const char usage_str[] = " -e, --entry=FUNC Set the DLL entry point function (default: DllMain)\n" " -E, --export=FILE Export the symbols defined in the .spec or .def file\n" " --external-symbols Allow linking to external symbols\n" -" -f FLAGS Compiler flags (-fPIC and -fasynchronous-unwind-tables are supported)\n" +" -f FLAGS Compiler flags (-fPIC, -fasynchronous-unwind-tables and -flto are supported)\n" " -F, --filename=DLLFILE Set the DLL filename (default: from input file name)\n" " --fake-module Create a fake binary module\n" " -h, --help Display this help message\n" @@ -405,6 +406,8 @@ static void option_callback( int optc, char *optarg ) if (!strcmp( optarg, "PIC") || !strcmp( optarg, "pic")) UsePIC = 1; else if (!strcmp( optarg, "asynchronous-unwind-tables")) unwind_tables = 1; else if (!strcmp( optarg, "no-asynchronous-unwind-tables")) unwind_tables = 0; + else if (!strcmp( optarg, "lto" )) UseLTO = 1; + else if (!strcmp( optarg, "no-lto" )) UseLTO = 0; /* ignore all other flags */ break; case 'h': @@ -569,6 +572,7 @@ int main(int argc, char **argv) if (is_pe()) unwind_tables = 1; files = parse_options( argc, argv, short_options, long_options, 0, option_callback ); + verbose = adjust_verbose_lto( UseLTO, verbose ); atexit( cleanup ); /* make sure we remove the output file on exit */ diff --git a/tools/winebuild/utils.c b/tools/winebuild/utils.c index 05595f86d37..1fbddde4741 100644 --- a/tools/winebuild/utils.c +++ b/tools/winebuild/utils.c @@ -303,6 +303,8 @@ struct strarray get_as_command(void) if (using_cc) { + /* disable LTO for assembly */ + append_lto_flags( &args, (UseLTO >= 0) ? 0 : -1, 1 /* prefer flags from env */ ); strarray_add( &args, "-xassembler" ); strarray_add( &args, "-c" ); if (force_pointer_size) @@ -345,6 +347,7 @@ struct strarray get_ld_command(void) } strarray_addall( &args, ld_command ); + append_lto_flags( &args, UseLTO, 1 /* prefer flags from env */ ); if (force_pointer_size) { @@ -380,8 +383,28 @@ const char *get_nm_command(void) { if (!nm_command.count) { - static const char * const commands[] = { "nm", "gnm", NULL }; - nm_command = find_tool( "nm", commands ); + static int init_env_nm = 0; + static const char * env_nm; + + if (!init_env_nm) + { + if ((env_nm = getenv( "WINE_NM" ))) + { + /* duplicate string if non-empty; otherwise set to NULL */ + env_nm = (env_nm[0]) ? xstrdup( env_nm ) : NULL; + } + init_env_nm = 1; + } + if (env_nm) + { + const char * _cmd[2] = { env_nm, NULL }; + nm_command = find_tool( "nm", _cmd ); + } + if (!nm_command.count) + { + static const char * const commands[] = { "nm", "gnm", NULL }; + nm_command = find_tool( "nm", commands ); + } } if (nm_command.count > 1) fatal_error( "multiple arguments in nm command not supported yet\n" ); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/7111
From: Konstantin Demin <rockdrilla(a)gmail.com> Signed-off-by: Konstantin Demin <rockdrilla(a)gmail.com> --- tools/winegcc/winegcc.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/tools/winegcc/winegcc.c b/tools/winegcc/winegcc.c index 0791aef8abd..2d7eed51ec3 100644 --- a/tools/winegcc/winegcc.c +++ b/tools/winegcc/winegcc.c @@ -178,6 +178,7 @@ struct options int unwind_tables; int strip; int pic; + int lto; int no_default_config; int build_id; const char* wine_objdir; @@ -544,6 +545,7 @@ static struct strarray get_link_args( struct options *opts, const char *output_n struct strarray flags = empty_strarray; strarray_addall( &link_args, opts->linker_args ); + append_lto_flags( &link_args, opts->lto, 1 /* prefer flags from env */ ); if (verbose > 1) strarray_add( &flags, "-v" ); @@ -831,6 +833,11 @@ static void compile(struct options* opts, const char* lang) break; } + if ((opts->processor == proc_cc) || (opts->processor == proc_cxx)) + { + append_lto_flags( &comp_args, opts->lto, 1 /* prefer flags from env */ ); + } + if (opts->target.platform == PLATFORM_WINDOWS || opts->target.platform == PLATFORM_CYGWIN || opts->target.platform == PLATFORM_MINGW) @@ -1013,6 +1020,7 @@ static struct strarray get_winebuild_args( struct options *opts, const char *tar strarray_add( &spec_args, binary ); if (verbose) strarray_add( &spec_args, "-v" ); if (keep_generated) strarray_add( &spec_args, "--save-temps" ); + append_lto_flags( &spec_args, opts->lto, 0 /* generic LTO flags */ ); if (target) { strarray_add( &spec_args, "--target" ); @@ -1667,6 +1675,7 @@ int main(int argc, char **argv) memset(&opts, 0, sizeof(opts)); opts.target = init_argv0_target( argv[0] ); opts.pic = 1; + opts.lto = -1; /* determine the processor type */ if (strendswith(argv[0], "winecpp")) opts.processor = proc_cpp; @@ -1818,6 +1827,10 @@ int main(int argc, char **argv) opts.pic = 1; else if (!strcmp("-fno-PIC", opts.args.str[i]) || !strcmp("-fno-pic", opts.args.str[i])) opts.pic = 0; + else if (!strcmp( "-flto", opts.args.str[i] )) + opts.lto = 1; + else if (!strcmp( "-fno-lto", opts.args.str[i] )) + opts.lto = 0; break; case 'i': if (!strcmp( "-isysroot", opts.args.str[i] )) opts.isysroot = opts.args.str[i + 1]; @@ -2107,6 +2120,7 @@ int main(int argc, char **argv) strarray_add( &opts.files, opts.args.str[i] ); } } + verbose = adjust_verbose_lto( opts.lto, verbose ); if (opts.force_pointer_size) set_target_ptr_size( &opts.target, opts.force_pointer_size ); if (opts.processor == proc_cpp) linking = 0; -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/7111
From: Konstantin Demin <rockdrilla(a)gmail.com> Signed-off-by: Konstantin Demin <rockdrilla(a)gmail.com> --- tools/makedep.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/tools/makedep.c b/tools/makedep.c index 3fe2d254fdf..62b4e35a53c 100644 --- a/tools/makedep.c +++ b/tools/makedep.c @@ -245,6 +245,7 @@ static const char *temp_file_name; static char cwd[PATH_MAX]; static int compile_commands_mode; static int silent_rules; +static int with_lto = 0; static int input_line; static int output_column; static FILE *output_file; @@ -273,6 +274,10 @@ static void fatal_perror( const char *msg, ... ) __attribute__ ((__format__ (__p static void output( const char *format, ... ) __attribute__ ((__format__ (__printf__, 1, 2))); static char *strmake( const char* fmt, ... ) __attribute__ ((__format__ (__printf__, 1, 2))); +static void output_lto_flags_source( struct makefile *make, struct incl_file *source, unsigned int arch, + int prefer_env ); +static void output_lto_flags_target( struct makefile *make, unsigned int arch, int prefer_env ); + /******************************************************************* * fatal_error */ @@ -2478,6 +2483,7 @@ static void output_winegcc_command( struct makefile *make, unsigned int arch ) output_filename( "--winebuild" ); output_filename( tools_path( make, "winebuild" )); } + output_lto_flags_target( make, arch, 0 /* generic LTO flags */ ); output_filenames( target_flags[arch] ); if (native_archs[arch] && !make->disabled[native_archs[arch]]) output_filenames( hybrid_target_flags[arch] ); @@ -3299,6 +3305,7 @@ static void output_source_one_arch( struct makefile *make, struct incl_file *sou output_filenames( defines ); output_filenames( cflags ); output_filename( var_cflags ); + output_lto_flags_source( make, source, arch, 1 /* prefer flags from env */ ); output( "\n" ); if (make->testdll && strendswith( source->name, ".c" ) && @@ -3573,6 +3580,7 @@ static void output_import_lib( struct makefile *make, unsigned int arch ) if (hybrid_arch) output_filenames_obj_dir( make, make->implib_files[hybrid_arch] ); output( "\n" ); output( "\t%s%s -w --implib -o $@", cmd_prefix( "BUILD" ), tools_path( make, "winebuild" ) ); + output_lto_flags_target( make, arch, 0 /* generic LTO flags */ ); if (!delay_load_flags[arch]) output_filename( "--without-dlltool" ); output_filenames( target_flags[hybrid_arch ? hybrid_arch : arch] ); if (make->is_win16) output_filename( "-m16" ); @@ -3608,6 +3616,7 @@ static void output_unix_lib( struct makefile *make ) output( "\n" ); output( "\t%s$(CC) -o $@", cmd_prefix( "CCLD" )); output_filenames( get_expanded_make_var_array( make, "UNIXLDFLAGS" )); + output_lto_flags_target( make, arch, 1 /* prefer flags from env */ ); output_filenames_obj_dir( make, make->unixobj_files ); output_filenames( unix_libs ); output_filename( "$(LDFLAGS)" ); @@ -3634,6 +3643,7 @@ static void output_static_lib( struct makefile *make, unsigned int arch ) output( "\n" ); output( "\t%s%s -w --staticlib -o $@", cmd_prefix( "BUILD" ), tools_path( make, "winebuild" )); output_filenames( target_flags[hybrid_arch ? hybrid_arch : arch] ); + output_lto_flags_target( make, arch, 0 /* generic LTO flags */ ); output_filenames_obj_dir( make, make->object_files[arch] ); if (hybrid_arch) output_filenames_obj_dir( make, make->object_files[hybrid_arch] ); if (!arch) output_filenames_obj_dir( make, make->unixobj_files ); @@ -3758,6 +3768,7 @@ static void output_programs( struct makefile *make ) output_filenames( deps ); output( "\n" ); output( "\t%s$(CC) -o $@", cmd_prefix( "CCLD" )); + output_lto_flags_target( make, arch, 1 /* prefer flags from env */ ); output_filenames_obj_dir( make, objs ); output_filenames( all_libs ); output_filename( "$(LDFLAGS)" ); @@ -4596,6 +4607,9 @@ static int parse_option( const char *opt ) case 'S': silent_rules = 1; break; + case 'L': + with_lto = 1; + break; default: fprintf( stderr, "Unknown option '%s'\n%s", opt, Usage ); exit(1); @@ -4615,6 +4629,47 @@ static unsigned int find_pe_arch( const char *arch ) } +/******************************************************************* + * output_lto_flags + */ +static void output_lto_flags( int use_lto, int prefer_env ) +{ + struct strarray lto_flags = empty_strarray; + append_lto_flags( <o_flags, use_lto, prefer_env ); + output_filenames( lto_flags ); +} + + +/******************************************************************* + * output_lto_flags_source + */ +static void output_lto_flags_source( struct makefile *make, struct incl_file *source, unsigned int arch, + int prefer_env ) +{ + if (!with_lto) return; + if (!make) return; + if (!source) return; + + (void) arch; /* mark as used */ + + output_lto_flags( with_lto, prefer_env ); +} + + +/******************************************************************* + * output_lto_flags_target + */ +static void output_lto_flags_target( struct makefile *make, unsigned int arch, int prefer_env ) +{ + if (!with_lto) return; + if (!make) return; + + (void) arch; /* mark as used */ + + output_lto_flags( with_lto, prefer_env ); +} + + /******************************************************************* * main */ -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/7111
From: Konstantin Demin <rockdrilla(a)gmail.com> Signed-off-by: Konstantin Demin <rockdrilla(a)gmail.com> --- tools/makedep.c | 126 +++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 120 insertions(+), 6 deletions(-) diff --git a/tools/makedep.c b/tools/makedep.c index 62b4e35a53c..73a151588a0 100644 --- a/tools/makedep.c +++ b/tools/makedep.c @@ -177,6 +177,7 @@ static struct strarray disabled_dirs[MAX_ARCHS]; static unsigned int native_archs[MAX_ARCHS]; static unsigned int hybrid_archs[MAX_ARCHS]; static struct strarray hybrid_target_flags[MAX_ARCHS]; +static struct strarray global_lto_skip[MAX_ARCHS]; struct makefile { @@ -209,6 +210,8 @@ struct makefile int is_win16; int is_exe; int disabled[MAX_ARCHS]; + int lto_skip[MAX_ARCHS]; + struct strarray lto_skip_src[MAX_ARCHS]; /* values generated at output time */ struct strarray in_files; @@ -4560,6 +4563,25 @@ static void load_sources( struct makefile *make ) for (i = 0; i < make->delayimports.count; i++) strarray_add_uniq( &delay_import_libs, get_base_name( make->delayimports.str[i] )); + + if (with_lto) + { + for (arch = 0; arch < archs.count; arch++) + { + const char * lto_skip; + + memset( &make->lto_skip_src[arch], 0, sizeof(struct strarray) ); + + lto_skip = get_expanded_arch_var( make, "LTO_SKIP", arch ); + make->lto_skip[arch] = var_to_bool( lto_skip ); + /* no need to parse source skiplist if target is marked as non-LTO */ + if (make->lto_skip[arch]) continue; + + value = get_expanded_arch_var_array( make, "LTO_SKIP_SRC", arch ); + for (i = 0; i < value.count; i++) + strarray_add( &make->lto_skip_src[arch], xstrdup( value.str[i] )); + } + } } @@ -4640,19 +4662,109 @@ static void output_lto_flags( int use_lto, int prefer_env ) } +/******************************************************************* + * parse_global_lto_skip_lists + */ +static void parse_global_lto_skip_lists( void ) +{ + unsigned int arch; + char *buffer; + FILE *file; + + for (arch = 0; arch < archs.count; arch++) + { + memset( &global_lto_skip[arch], 0, sizeof(struct strarray) ); + + if (arch) + input_file_name = root_src_dir_path(strmake( "tools/lto-skip.%s.list", archs.str[arch] )); + else + input_file_name = root_src_dir_path( "tools/lto-skip.list" ); + /* skip nonexistent files */ + if (!(file = fopen( input_file_name, "r" ))) + { + input_file_name = NULL; + continue; + } + input_line = 0; + + while ((buffer = get_line( file ))) + { + if (strlen(buffer) == 0) continue; /* empty line */ + if (*buffer == '#') continue; /* comment */ + strarray_add( &global_lto_skip[arch], xstrdup( buffer )); + } + (void) fclose( file ); + input_file_name = NULL; + input_line = 0; + } +} + + +/******************************************************************* + * is_lto_enabled_source + */ +static int is_lto_enabled_source( struct makefile *make, struct incl_file *source, unsigned int arch ) +{ + if (!with_lto) return 0; + if (!make) return 0; + if (!source) return 0; + + /* target config: any arch */ + if (strarray_exists( make->lto_skip_src[0], source->name )) + return 0; + + if (arch) + { + /* target config: specific arch */ + if (strarray_exists( make->lto_skip_src[arch], source->name )) + return 0; + + /* global config: specific arch */ + if (strarray_exists( global_lto_skip[arch], source->filename )) + return 0; + } + + /* global config: any arch */ + if (strarray_exists( global_lto_skip[0], source->filename )) + return 0; + + return 1; +} + + +/******************************************************************* + * is_lto_enabled_target + */ +static int is_lto_enabled_target( struct makefile *make, unsigned int arch ) +{ + if (!with_lto) return 0; + if (!make) return 0; + + /* any arch */ + if (make->lto_skip[0]) return 0; + + /* specific arch */ + if (arch && make->lto_skip[arch]) + return 0; + + return 1; +} + + /******************************************************************* * output_lto_flags_source */ static void output_lto_flags_source( struct makefile *make, struct incl_file *source, unsigned int arch, int prefer_env ) { + int use_lto = 0; + if (!with_lto) return; if (!make) return; if (!source) return; - (void) arch; /* mark as used */ - - output_lto_flags( with_lto, prefer_env ); + use_lto = is_lto_enabled_target( make, arch ) && is_lto_enabled_source( make, source, arch ); + output_lto_flags( use_lto, prefer_env ); } @@ -4661,12 +4773,13 @@ static void output_lto_flags_source( struct makefile *make, struct incl_file *so */ static void output_lto_flags_target( struct makefile *make, unsigned int arch, int prefer_env ) { + int use_lto = 0; + if (!with_lto) return; if (!make) return; - (void) arch; /* mark as used */ - - output_lto_flags( with_lto, prefer_env ); + use_lto = is_lto_enabled_target( make, arch ); + output_lto_flags( use_lto, prefer_env ); } @@ -4796,6 +4909,7 @@ int main( int argc, char *argv[] ) for (i = 0; i < subdirs.count; i++) submakes[i] = parse_makefile( subdirs.str[i] ); + if (with_lto) parse_global_lto_skip_lists(); load_sources( top_makefile ); load_sources( include_makefile ); for (i = 0; i < subdirs.count; i++) -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/7111
From: Konstantin Demin <rockdrilla(a)gmail.com> Signed-off-by: Konstantin Demin <rockdrilla(a)gmail.com> --- configure | 19 +++++++++++++++++++ configure.ac | 12 ++++++++++++ 2 files changed, 31 insertions(+) diff --git a/configure b/configure index ef7c99dd8e8..a435030b4d0 100755 --- a/configure +++ b/configure @@ -922,6 +922,7 @@ enable_maintainer_mode enable_sast enable_silent_rules enable_werror +enable_lto with_alsa with_capi with_coreaudio @@ -2522,6 +2523,7 @@ Optional Features: Clang --enable-silent-rules use silent build rules (override: "make V=1") --enable-werror treat compilation warnings as errors + --enable-lto build with LTO (EXPERIMENTAL) --disable-largefile omit support for large files --disable-year2038 don't support timestamps after 2038 @@ -4340,6 +4342,12 @@ then : enableval=$enable_werror; fi +# Check whether --enable-lto was given. +if test ${enable_lto+y} +then : + enableval=$enable_lto; +fi + # Check whether --with-alsa was given. @@ -10111,6 +10119,11 @@ do esac done +if test "x$enable_lto" = xyes +then + as_fn_append EXTRACFLAGS " -D__WINE_LTO_BUILD" +fi + for wine_arch in $cross_archs $extra_arch do case "x$with_mingw" in @@ -10399,6 +10412,11 @@ fi eval LDFLAGS=\$${wine_arch}_LDFLAGS eval "${wine_arch}_EXTRACFLAGS=\"-D__WINE_PE_BUILD -Wall\"" + if test "x$enable_lto" = xyes + then + as_fn_append ${wine_arch}_EXTRACFLAGS " -D__WINE_LTO_BUILD" + fi + target="" set x $CC shift @@ -22093,6 +22111,7 @@ printf %s "creating Makefile rules..." >&6 makedep_flags=" -C" test "x$enable_silent_rules" = xyes && makedep_flags="$makedep_flags -S" +test "x$enable_lto" = xyes && makedep_flags="$makedep_flags -L" wine_srcdir= test "$srcdir" = . || wine_srcdir="$srcdir/" diff --git a/configure.ac b/configure.ac index 274591f5f53..15ac2772687 100644 --- a/configure.ac +++ b/configure.ac @@ -24,6 +24,7 @@ AC_ARG_ENABLE(maintainer-mode, AS_HELP_STRING([--enable-maintainer-mode],[enable AC_ARG_ENABLE(sast, AS_HELP_STRING([--enable-sast],[enable static application security testing using Clang])) AC_ARG_ENABLE(silent-rules, AS_HELP_STRING([--enable-silent-rules],[use silent build rules (override: "make V=1")])) AC_ARG_ENABLE(werror, AS_HELP_STRING([--enable-werror],[treat compilation warnings as errors])) +AC_ARG_ENABLE(lto, AS_HELP_STRING([--enable-lto],[build with LTO (EXPERIMENTAL)])) AC_ARG_WITH(alsa, AS_HELP_STRING([--without-alsa],[do not use the Alsa sound support])) AC_ARG_WITH(capi, AS_HELP_STRING([--without-capi],[do not use CAPI (ISDN support)])) @@ -810,6 +811,11 @@ do esac done +if test "x$enable_lto" = xyes +then + AS_VAR_APPEND([EXTRACFLAGS],[" -D__WINE_LTO_BUILD"]) +fi + for wine_arch in $cross_archs $extra_arch do case "x$with_mingw" in @@ -844,6 +850,11 @@ do AS_VAR_COPY([LDFLAGS],[${wine_arch}_LDFLAGS]) AS_VAR_SET([${wine_arch}_EXTRACFLAGS],["-D__WINE_PE_BUILD -Wall"]) + if test "x$enable_lto" = xyes + then + AS_VAR_APPEND([${wine_arch}_EXTRACFLAGS],[" -D__WINE_LTO_BUILD"]) + fi + target="" set x $CC shift @@ -2386,6 +2397,7 @@ AS_ECHO_N("creating Makefile rules...") >&AS_MESSAGE_FD makedep_flags=" -C" test "x$enable_silent_rules" = xyes && makedep_flags="$makedep_flags -S" +test "x$enable_lto" = xyes && makedep_flags="$makedep_flags -L" wine_srcdir= test "$srcdir" = . || wine_srcdir="$srcdir/" -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/7111
From: Konstantin Demin <rockdrilla(a)gmail.com> Signed-off-by: Konstantin Demin <rockdrilla(a)gmail.com> --- tools/lto-skip.arm.list | 3 +++ tools/lto-skip.i386.list | 21 +++++++++++++++++++++ tools/lto-skip.list | 2 ++ tools/lto-skip.x86_64.list | 6 ++++++ 4 files changed, 32 insertions(+) create mode 100644 tools/lto-skip.arm.list create mode 100644 tools/lto-skip.i386.list create mode 100644 tools/lto-skip.list create mode 100644 tools/lto-skip.x86_64.list diff --git a/tools/lto-skip.arm.list b/tools/lto-skip.arm.list new file mode 100644 index 00000000000..8ba52bcae81 --- /dev/null +++ b/tools/lto-skip.arm.list @@ -0,0 +1,3 @@ +# __wine_setjmpex +# __wine_longjmp +dlls/winecrt0/setjmp.c diff --git a/tools/lto-skip.i386.list b/tools/lto-skip.i386.list new file mode 100644 index 00000000000..74c66af6ec4 --- /dev/null +++ b/tools/lto-skip.i386.list @@ -0,0 +1,21 @@ +# __wine_setjmpex +# __wine_longjmp +dlls/winecrt0/setjmp.c + +# RtlUshortByteSwap(a)4 +# RtlUlongByteSwap(a)4 +# RtlUlonglongByteSwap(a)8 +dlls/ntdll/rtl.c + +# InterlockedCompareExchange(a)12 +# InterlockedExchange(a)8 +# InterlockedExchangeAdd(a)8 +# InterlockedIncrement(a)4 +# InterlockedDecrement(a)4 +dlls/kernel32/sync.c + +# ExitProcess(a)4 +dlls/kernel32/process.c + +# _ftol +dlls/msvcrt/math.c diff --git a/tools/lto-skip.list b/tools/lto-skip.list new file mode 100644 index 00000000000..907c7e40788 --- /dev/null +++ b/tools/lto-skip.list @@ -0,0 +1,2 @@ +# _chkstk (i386) / __chkstk (others) +dlls/ntoskrnl.exe/ntoskrnl.c diff --git a/tools/lto-skip.x86_64.list b/tools/lto-skip.x86_64.list new file mode 100644 index 00000000000..1afb09c2b89 --- /dev/null +++ b/tools/lto-skip.x86_64.list @@ -0,0 +1,6 @@ +# __wine_setjmpex +# __wine_longjmp +dlls/winecrt0/setjmp.c + +# GetProcAddress +dlls/kernel32/module.c -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/7111
I've reduced skiplists as much as possible and added comments about missing symbols during LTO. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7111#note_97949
On Sun Mar 16 08:22:33 2025 +0000, Konstantin Demin wrote:
I've reduced skiplists as much as possible and added comments about missing symbols during LTO. However, this MR depends on https://gitlab.winehq.org/wine/wine/-/merge_requests/7119 to be merged first. Feel free to add the patches yourself, I'm no longer interested in trying to merge that. Best of luck.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7111#note_97951
participants (3)
-
Konstantin Demin -
Konstantin Demin (＠rockdrilla)
-
William Horvath (＠whrvt)