[PATCH 0/1] MR8565: d3dx10/tests: Add a test for effect compiler behavior.

[Nikolay Sivov (＠nsivov)]

This most likely means d3dx10_N. should be using corresponding d3dcompiler_N.dll.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8565

[PATCH 1/1] d3dx10/tests: Add a test for effect compiler behavior.

[Nikolay Sivov]

From: Nikolay Sivov <nsivov(a)codeweavers.com>

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>
---
 dlls/d3dx10_43/tests/d3dx10.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/dlls/d3dx10_43/tests/d3dx10.c b/dlls/d3dx10_43/tests/d3dx10.c
index f7f2e2e32f8..592131b9b75 100644
--- a/dlls/d3dx10_43/tests/d3dx10.c
+++ b/dlls/d3dx10_43/tests/d3dx10.c
@@ -4319,6 +4319,7 @@ todo_wine {
 
 static void test_create_effect_from_memory(void)
 {
+    D3D10_EFFECT_DESC desc;
     ID3D10Device *device;
     ID3D10Effect *effect;
     ID3D10Blob *errors;
@@ -4378,6 +4379,16 @@ static void test_create_effect_from_memory(void)
     ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr);
     ok(!errors, "Got unexpected errors %p.\n", errors);
     ok(!!effect && effect != (ID3D10Effect *)0xdeadbeef, "Got unexpected effect %p.\n", effect);
+
+    /* Empty buffers are always included before version 40. */
+    hr = effect->lpVtbl->GetDesc(effect, &desc);
+    ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr);
+#if D3DX10_SDK_VERSION > 40
+    ok(desc.ConstantBuffers == 1, "Unexpected buffer count.\n");
+#else
+    todo_wine
+    ok(desc.ConstantBuffers == 2, "Unexpected buffer count.\n");
+#endif
     effect->lpVtbl->Release(effect);
 
     refcount = ID3D10Device_Release(device);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/8565

[PATCH 0/1] MR8565: d3dx10/tests: Add a test for effect compiler behavior. - approved

[Matteo Bruni (＠Mystral)]

This merge request was approved by Matteo Bruni.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8565

[Matteo Bruni (＠Mystral)]

Clarification for posterity: the empty CB is "$Globals".

It might be nice to add a check for the extra CB's name if there are going to be more tests around this. Not particularly worth of attention right now.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8565#note_110634

[Nikolay Sivov (＠nsivov)]

On Tue Jul 22 14:25:15 2025 +0000, Matteo Bruni wrote:
> Clarification for posterity: the empty CB is "$Globals".
> It might be nice to add a check for the extra CB's name if there are
> going to be more tests around this. Not particularly worth of attention
> right now.
> Clarification for the clarification, it's not necessarily $Globals. User buffers could be empty too.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8565#note_110653

[Matteo Bruni (＠Mystral)]

On Tue Jul 22 14:25:15 2025 +0000, Nikolay Sivov wrote:
> Clarification for the clarification, it's not necessarily $Globals. User
> buffers could be empty too.
> Sure, I was referring specifically to the test :slight_smile:

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8565#note_110654