Re: [PATCH v20 0/14] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
31 Oct
2023
31 Oct
'23
8:09 p.m.
On Tue Oct 31 18:36:04 2023 +0000, Zebediah Figura wrote:
We can delete this line. https://learn.microsoft.com/en-us/windows/win32/api/strmif/nf-strmif-iamstre... says that parameter can return non-NULL, so it felt wrong to potentially leak it.
But that same page says this specific filter, and every Windows builtin, always returns NULL, so checking for something that's documented to never happen is also kinda wrong. Which means I have no particular opinion in either direction. If you do, let's go with that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_50384
856
Age (days ago)
856
Last active (days ago)
0 comments
1 participants
participants (1)
-
Alfred Agrell (@Alcaro)