[PATCH v2 0/1] MR2190: winspool: Initialize nt_ppd in add_printer_driver.
This prevents a bad free if RtlDosPathNameToNtPathName_U fails. I should have included this change in commit 69ea31ffb594eadb2b35c3f713d89f5488ee86f2, sorry. -- v2: winspool: Initialize nt_ppd in add_printer_driver. https://gitlab.winehq.org/wine/wine/-/merge_requests/2190
From: Alex Henrie <alexhenrie24(a)gmail.com> This prevents a bad free if RtlDosPathNameToNtPathName_U fails. --- dlls/winspool.drv/info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/winspool.drv/info.c b/dlls/winspool.drv/info.c index 61017104ab1..456d5e2ecdf 100644 --- a/dlls/winspool.drv/info.c +++ b/dlls/winspool.drv/info.c @@ -635,7 +635,7 @@ static BOOL add_printer_driver( const WCHAR *name, const WCHAR *ppd_dir ) { WCHAR *ppd = get_ppd_filename( ppd_dir, name ); struct get_ppd_params ppd_params; - UNICODE_STRING nt_ppd; + UNICODE_STRING nt_ppd = { .Buffer = NULL }; DRIVER_INFO_3W di3; unsigned int i; BOOL res = FALSE; -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/2190
This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2190
participants (3)
-
Alex Henrie -
Alex Henrie (@alexhenrie) -
Huw Davies (@huw)