Re: [PATCH v5 0/4] MR406: win32u: Introduce new add_modes device manager callback.
3 Aug
2022
3 Aug
'22
6:25 a.m.
On Mon Aug 1 07:56:19 2022 +0000, Zhiyi Zhang wrote:
Hi, R��mi. This is causing a new Coverity report. In NtUserChangeDisplaySettings(), default_mode is passed to read_registry_settings(), which eventually calls read_adapter_mode() and then writes to the mode + 1. This is out of bound access because default_mode is not an array. I think the correct fix is to not set dmDriverExtra for ENUM_REGISTRY_SETTINGS. It writes only if `dmDriverExtra` is not zero. I think in both these two locations it is initialized to 0. It is used to read full modes for the available mode list.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/406#note_5556
1230
Age (days ago)
1230
Last active (days ago)
0 comments
1 participants
participants (1)
-
Rémi Bernon